LayoutTests/fast/dom/NodeFilterCondition-leak-document.html - Issue 21274004: Fix Document leak from NodeFilter.

Side by Side Diff: LayoutTests/fast/dom/NodeFilterCondition-leak-document.html

Issue 21274004: Fix Document leak from NodeFilter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add assertions to wrap Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../fast/js/resources/js-test-pre.js"></script>	3 <script src="../js/resources/js-test-pre.js"></script>

4 </head>	4 </head>

5 <body>	5 <body>

6 <span>This test only runs on DumpRenderTree, as it requires existence of win dow.internals and cross-domain resource access check disabled.</span>	6 <span>This test only runs on DumpRenderTree, as it requires existence of win dow.internals and cross-domain resource access check disabled.</span>

7 <iframe id="f" src='about:blank'></iframe>	7 <iframe id="f" src='about:blank'></iframe>

8 <script>	8 <script>

9 description("This test asserts that document doesn't leak when a selecti on is created inside the document.");	9 description("This test asserts that document doesn't leak when a NodeFil ter callback referencing the document is created.");

10	10

11 jsTestIsAsync = true;	11 jsTestIsAsync = true;

12 if (!window.internals)	12 if (!window.internals)

13 finishJSTest();	13 finishJSTest();

14	14

15 function countNumberOfLiveDocuments() {	15 function countNumberOfLiveDocuments() {

16 gc();	16 gc();

17 return window.internals.numberOfLiveDocuments();	17 return window.internals.numberOfLiveDocuments();

18 }	18 }

19	19

(...skipping 15 matching lines...) Expand all Loading...
35	35

36 frame.onload = function() {	36 frame.onload = function() {

37 // document unloaded...	37 // document unloaded...

38	38

39 numberOfDocumentsAfter = countNumberOfLiveDocuments();	39 numberOfDocumentsAfter = countNumberOfLiveDocuments();

40 shouldBe("numberOfDocumentsAfter", "numberOfDocumentsBefore");	40 shouldBe("numberOfDocumentsAfter", "numberOfDocumentsBefore");

41 finishJSTest();	41 finishJSTest();

42 }	42 }

43 frame.src = 'about:blank';	43 frame.src = 'about:blank';

44 }	44 }

45 frame.src='data:text/html;charset=utf-8,<span id="t"></span>';	45 var src = 'data:text/html;charset=utf-8,<script>' +

	46 'keepNodeIterator = document.createNodeIterator(document, Node Filter.SHOW_ELEMENT, function(node) { return NodeFilter.SHOW_ELEMENT; }, false); ' +

	47 'keepTreeWalker = document.createTreeWalker(document, NodeFilt er.SHOW_ELEMENT, function(node) { return NodeFilter.SHOW_ELEMENT; }, false);' +

	48 '</script'+'>';

	49 frame.src = src;
	haraken 2013/08/01 13:32:20 I'm sorry I was misreading the tests in your previ I'm sorry I was misreading the tests in your previous patch. You're testing multiple things in this file, which are not good. In particular, this is a test for GC bugs, so we want to minimize the test case. Shall we split the tests into 3 files? - The test file for setPosition(). - The test file for createNodeIterator(). - The test file for createTreeWalker(). Needless to say, you don't need to run setPosition() in the latter two tests. kouhei (in TOK) 2013/08/02 03:26:57 Done. Show quoted text On 2013/08/01 13:32:20, haraken wrote: > > I'm sorry I was misreading the tests in your previous patch. You're testing > multiple things in this file, which are not good. In particular, this is a test > for GC bugs, so we want to minimize the test case. > > Shall we split the tests into 3 files? > > - The test file for setPosition(). > - The test file for createNodeIterator(). > - The test file for createTreeWalker(). > > Needless to say, you don't need to run setPosition() in the latter two tests. Done.
46 </script>	50 </script>

47 <script src="../../fast/js/resources/js-test-post.js"></script>	51 <script src="../js/resources/js-test-post.js"></script>

48 </body>	52 </body>

49 </html>	53 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/NodeFilterCondition-leak-document-expected.txt » ('j') | Source/bindings/v8/V8Binding.cpp » ('J')