Fix Document leak from NodeFilter.

Source/bindings/v8/V8NodeFilterCondition.cpp

 /*
  * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 16 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "bindings/v8/V8NodeFilterCondition.h"
 
 #include "V8Node.h"
 #include "bindings/v8/ScriptController.h"
 #include "bindings/v8/ScriptState.h"
+#include "bindings/v8/V8HiddenPropertyName.h"
 #include "core/dom/Node.h"
 #include "core/dom/NodeFilter.h"
 #include "wtf/OwnArrayPtr.h"
 
 namespace WebCore {
 
-V8NodeFilterCondition::V8NodeFilterCondition(v8::Handle<v8::Value> filter)
+V8NodeFilterCondition::V8NodeFilterCondition(v8::Handle<v8::Value> filter, v8::Handle<v8::Object> owner)
     : m_filter(filter)
 {
+    owner->SetHiddenValue(V8HiddenPropertyName::condition(), filter);
+    m_filter.makeWeak(this, &makeWeakCallback);
 }
 
 V8NodeFilterCondition::~V8NodeFilterCondition()
 {
 }
 
 short V8NodeFilterCondition::acceptNode(ScriptState* state, Node* node) const
 {
     ASSERT(v8::Context::InContext());
 
     v8::Isolate* isolate = state->isolate();
     v8::HandleScope handleScope(isolate);
     v8::Handle<v8::Value> filter = m_filter.newLocal(isolate);
     if (!filter->IsObject())

[dominicc (has gone to gerrit), 2013/07/31 14:09:55]

Is it worth asserting that this is non-empty?

[kouhei (in TOK), 2013/08/01 01:12:24]

Done.

         return NodeFilter::FILTER_ACCEPT;
 
     v8::TryCatch exceptionCatcher;
 
     v8::Handle<v8::Function> callback;
     if (filter->IsFunction())
         callback = v8::Handle<v8::Function>::Cast(filter);
     else {
         v8::Local<v8::Value> value = filter->ToObject()->Get(v8::String::NewSymbol("acceptNode"));
         if (!value->IsFunction()) {
@@ skipping 12 matching lines @@
     if (exceptionCatcher.HasCaught()) {
         state->setException(exceptionCatcher.Exception());
         return NodeFilter::FILTER_REJECT;
     }
 
     ASSERT(!result.IsEmpty());
 
     return result->Int32Value();
 }
 
+void V8NodeFilterCondition::makeWeakCallback(v8::Isolate*, v8::Persistent<v8::Value>*, V8NodeFilterCondition* condition)
+{
+    condition->m_filter.clear();
+}
+
 } // namespace WebCore