Fix Document leak from NodeFilter.

Source/bindings/v8/V8Binding.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "bindings/v8/V8Binding.h"
 
 #include "V8DOMStringList.h"
 #include "V8Element.h"
+#include "V8NodeFilter.h"
 #include "V8Window.h"
 #include "V8WorkerGlobalScope.h"
 #include "V8XPathNSResolver.h"
 #include "bindings/v8/ScriptController.h"
 #include "bindings/v8/V8NodeFilterCondition.h"
 #include "bindings/v8/V8ObjectConstructor.h"
 #include "bindings/v8/V8WindowShell.h"
 #include "bindings/v8/WorkerScriptController.h"
 #include "bindings/v8/custom/V8CustomXPathNSResolver.h"
 #include "core/dom/DOMStringList.h"
@@ skipping 89 matching lines @@
 
 Vector<v8::Handle<v8::Value> > toVectorOfArguments(const v8::FunctionCallbackInfo<v8::Value>& args)
 {
     Vector<v8::Handle<v8::Value> > result;
     size_t length = args.Length();
     for (size_t i = 0; i < length; ++i)
         result.append(args[i]);
     return result;
 }
 
-PassRefPtr<NodeFilter> toNodeFilter(v8::Handle<v8::Value> callback)
+PassRefPtr<NodeFilter> toNodeFilter(v8::Handle<v8::Value> callback, v8::Isolate* isolate)
 {
-    return NodeFilter::create(V8NodeFilterCondition::create(callback));
+    RefPtr<NodeFilter> filter = NodeFilter::create();
+
+    // FIXME: Should pass in appropriate creationContext
+    v8::Handle<v8::Object> filterWrapper = toV8(PassRefPtr<NodeFilter>(filter), v8::Handle<v8::Object>(), isolate).As<v8::Object>();

[abarth-chromium, 2013/07/31 06:04:14]

PassRefPtr<NodeFilter>(filter)  ->  filter.get()
^^ That should work.

[kouhei (in TOK), 2013/07/31 06:21:34]

Done.

+
+    RefPtr<NodeFilterCondition> condition = V8NodeFilterCondition::create(callback, filterWrapper);
+    filter->setCondition(condition.release());
+
+    return filter.release();
 }
 
 static const int8_t kMaxInt8 = 127;
 static const int8_t kMinInt8 = -128;
 static const uint8_t kMaxUInt8 = 255;
 const int32_t kMaxInt32 = 0x7fffffff;
 const int32_t kMinInt32 = -kMaxInt32 - 1;
 const uint32_t kMaxUInt32 = 0xffffffff;
 const int64_t kJSMaxInteger = 0x20000000000000LL - 1; // 2^53 - 1, maximum integer exactly representable in ECMAScript.
 
@@ skipping 394 matching lines @@
     return DOMWrapperWorld::isolatedWorld(v8::Context::GetCurrent());
 }
 
 v8::Local<v8::Value> getHiddenValueFromMainWorldWrapper(v8::Isolate* isolate, ScriptWrappable* wrappable, v8::Handle<v8::String> key)
 {
     v8::Local<v8::Object> wrapper = wrappable->newLocalWrapper(isolate);
     return wrapper.IsEmpty() ? v8::Local<v8::Value>() : wrapper->GetHiddenValue(key);
 }
 
 } // namespace WebCore