Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2127393002: Prevent to measure the whole word when break-all (Closed)

Created:
4 years, 5 months ago by kojii
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Prevent to measure the whole word when break-all This patch applies the same heuristic fix as break-word to break-all. Since the switch to the complex path, r385693 fixed the performance and correctness issue of break-word and break-all in common cases. However, it also introduced a performance regression when a word is really long, such as minimized JS. This can be fixed by taking over the ShapeResult to the next lines as Gecko does, but it will require larger overhaul of the line breaker and need more time to bake. As an interim fix, r387974 introduced a heuristic fix for break-word. This patch applies the same heuristic to break-all. This patch also revealed that the fix for crbug.com/603679 was not correct. MidWordBreak must be recomputed when floats pushed the line down and available width changed. This patch includes the fix. BUG=622810, 603679 Review-Url: https://codereview.chromium.org/2077313002 Cr-Commit-Position: refs/heads/master@{#403830} (cherry picked from commit d24d249700deef0ed63bf12ebb6af3b28f8225fb) Committed: https://chromium.googlesource.com/chromium/src/+/8b6b39703c17c81d31c03ed8d6b4ee9991a246d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -14 lines) Patch
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 6 chunks +45 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kojii
4 years, 5 months ago (2016-07-08 07:11:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8b6b39703c17c81d31c03ed8d6b4ee9991a246d3 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698