services/ui/public/interfaces/accessibility_manager.mojom - Issue 2127383003: mus: Introduce high-contrast mode in mus.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/ui/public/interfaces/accessibility_manager.mojom

Issue 2127383003: mus: Introduce high-contrast mode in mus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module ui.mojom;

	6

	7 // Allows controlling accessibility in the UI service. Only one client at a time

	8 // can connect to AccessibilityManager. If a new client connects to it, then any

	9 // previously connected client is disconnected.

	10 interface AccessibilityManager {

	11 // Enables (or disables) high contrast mode.

	12 SetHighContrastMode(bool enabled);
	sadrul 2016/07/08 16:22:18 Would it make sense to have "enum ServiceState { E Would it make sense to have "enum ServiceState { ENABLE, DISABLE, TOGGLE }; SetHighContrastMode(ServiceState);" instead? sky 2016/07/08 16:45:00 Seems like the caller is going to know what state Show quoted text On 2016/07/08 16:22:18, sadrul wrote: > Would it make sense to have "enum ServiceState { ENABLE, DISABLE, TOGGLE }; > SetHighContrastMode(ServiceState);" instead? Seems like the caller is going to know what state they want, right? When would you envision TOGGLE being used? sadrul 2016/07/08 17:33:25 The system-tray gets an entry to toggle the flag, Show quoted text On 2016/07/08 16:45:00, sky wrote: > On 2016/07/08 16:22:18, sadrul wrote: > > Would it make sense to have "enum ServiceState { ENABLE, DISABLE, TOGGLE }; > > SetHighContrastMode(ServiceState);" instead? > > Seems like the caller is going to know what state they want, right? When would > you envision TOGGLE being used? The system-tray gets an entry to toggle the flag, but it knows whether it is turned on or not, so yeah, toggle doesn't actually need to be in the API.
	13 };

OLD	NEW

« services/ui/manifest.json ('K') | « services/ui/public/interfaces/BUILD.gn ('k') | services/ui/service.h » ('j') | services/ui/ws/accessibility_manager.cc » ('J')