Open hyperlinks in PDF in a new tab when middle mouse clicking.

chrome/browser/pdf/pdf_extension_test.cc

Index: chrome/browser/pdf/pdf_extension_test.cc
diff --git a/chrome/browser/pdf/pdf_extension_test.cc b/chrome/browser/pdf/pdf_extension_test.cc
index 3e11df7829e3d3e63da939418497da44bdc69f4c..970daeabe762f8149cc8e47ee3b6f9ac212d5cec 100644
--- a/chrome/browser/pdf/pdf_extension_test.cc
+++ b/chrome/browser/pdf/pdf_extension_test.cc
@@ -39,6 +39,7 @@
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
+#include "content/public/browser/notification_service.h"
 #include "content/public/browser/plugin_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
@@ -585,3 +586,52 @@ IN_PROC_BROWSER_TEST_F(PDFExtensionTest, PdfAccessibility) {
       << "Expected:\n" << expected_ax_tree
       << "\n\nActual:\n" << ax_tree_dump;
 }
+
+IN_PROC_BROWSER_TEST_F(PDFExtensionTest, LinkMiddleClick) {
+  GURL test_pdf_url(embedded_test_server()->GetURL("/pdf/test-link.pdf"));
+  ui_test_utils::NavigateToURL(browser(), test_pdf_url);
+
+  content::WebContents* web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  ASSERT_TRUE(pdf_extension_test_util::EnsurePDFHasLoaded(web_contents));
+
+  int x;
+  ASSERT_TRUE(content::ExecuteScriptAndExtractInt(
+      web_contents,
+      "window.addEventListener('message', function(event) {"
+      "  if (event.data.type == 'getLinkPositionReply')"
+      "    window.domAutomationController.send(Math.floor(event.data.x));"
+      "  window.removeEventListener(event.type, arguments.callee);"
+      "});"
+      "document.getElementsByTagName('embed')[0].postMessage("
+      "    {type: 'getLinkPosition'});",
+      &x));
+
+  int y;
+  ASSERT_TRUE(content::ExecuteScriptAndExtractInt(
+      web_contents,
+      "window.addEventListener('message', function(event) {"
+      "  if (event.data.type == 'getLinkPositionReply')"
+      "    window.domAutomationController.send(Math.floor(event.data.y));"
+      "  window.removeEventListener(event.type, arguments.callee);"
+      "});"
+      "document.getElementsByTagName('embed')[0].postMessage("
+      "    {type: 'getLinkPosition'});",

[Lei Zhang, 2016/07/08 18:02:35]

It feels like a bit more work to have to post 2 getLinkPosition messages. Can we
maybe post getLinkPosition onc, save the coordinates somewhere in JS somewhere,
and make a couple calls to retrieve them?

[jaepark, 2016/07/08 20:58:16]

Done.

+      &y));
+
+  gfx::Point point(x, y);
+  content::WindowedNotificationObserver observer(
+      chrome::NOTIFICATION_TAB_ADDED,
+      content::NotificationService::AllSources());
+  content::SimulateMouseClickAt(web_contents, 0,
+      blink::WebMouseEvent::ButtonMiddle, point);
+  observer.Wait();
+
+  int tab_count = browser()->tab_strip_model()->count();
+  ASSERT_EQ(2, tab_count);
+
+  const GURL& url =
+      browser()->tab_strip_model()->GetActiveWebContents()->GetURL();
+  ASSERT_EQ(std::string("https://www.google.com/"), url.spec());

[Lei Zhang, 2016/07/08 18:02:35]

Can we do example.com and add:

host_resolver()->AddRule("example.com", "127.0.0.1");

so we don't hit the real example.com?

[jaepark, 2016/07/08 20:58:16]

Done.

+}
+