Open hyperlinks in PDF in a new tab when middle mouse clicking.

chrome/browser/pdf/pdf_extension_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <vector>
 
 #include "base/base_paths.h"
 #include "base/files/file_enumerator.h"
@@ skipping 21 matching lines @@
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/zoom/page_zoom.h"
 #include "components/zoom/test/zoom_test_utils.h"
 #include "components/zoom/zoom_controller.h"
 #include "content/public/browser/browser_accessibility_state.h"
 #include "content/public/browser/browser_plugin_guest_manager.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
+#include "content/public/browser/notification_service.h"
 #include "content/public/browser/plugin_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/common/manifest_handlers/mime_types_handler.h"
 #include "extensions/test/result_catcher.h"
+#include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "url/gurl.h"
 
 #if defined(TOOLKIT_VIEWS) && !defined(OS_MACOSX)
 #include "chrome/browser/ui/views/location_bar/zoom_bubble_view.h"
 #endif
 
 const int kNumberLoadTestParts = 10;
 
@@ skipping 517 matching lines @@
       "      paragraph\n"
       "        staticText '3'\n"
       "          inlineTextBox '3'\n";
 
   // Using ASSERT_TRUE deliberately instead of ASSERT_EQ or ASSERT_STREQ
   // in order to print a more readable message if the strings differ.
   ASSERT_TRUE(expected_ax_tree == ax_tree_dump)
       << "Expected:\n" << expected_ax_tree
       << "\n\nActual:\n" << ax_tree_dump;
 }
+
+IN_PROC_BROWSER_TEST_F(PDFExtensionTest, LinkMiddleClick) {
+  host_resolver()->AddRule("www.example.com", "127.0.0.1");
+  GURL test_pdf_url(embedded_test_server()->GetURL("/pdf/test-link.pdf"));
+  content::WebContents* guest_contents = LoadPdfGetGuestContents(test_pdf_url);
+  ASSERT_TRUE(guest_contents);
+  content::WebContents* web_contents =

[Lei Zhang, 2016/07/14 00:03:39]

Move this down to line ~627, closer to where it's used, whenever possible.

[jaepark, 2016/07/14 00:59:40]

Done.

+      browser()->tab_strip_model()->GetActiveWebContents();
+
+  // The link position of the test-link.pdf in page coordinates is (110, 110).
+  // Convert the link position from page coordinates to screen coordinates.
+  ASSERT_TRUE(content::ExecuteScript(guest_contents,
+      "var visiblePage = viewer.viewport.getMostVisiblePage();"
+      "var visiblePageDimensions ="
+      "    viewer.viewport.getPageScreenRect(visiblePage);"
+      "var viewportPosition = viewer.viewport.position;"
+      "var screenOffsetX = visiblePageDimensions.x - viewportPosition.x;"
+      "var screenOffsetY = visiblePageDimensions.y - viewportPosition.y;"
+      "var linkScreenPositionX = Math.floor(110 + screenOffsetX);"
+      "var linkScreenPositionY = Math.floor(110 + screenOffsetY);"));
+
+  int x;
+  ASSERT_TRUE(content::ExecuteScriptAndExtractInt(
+      guest_contents,
+      "window.domAutomationController.send(linkScreenPositionX);",
+      &x));
+
+  int y;
+  ASSERT_TRUE(content::ExecuteScriptAndExtractInt(
+      guest_contents,
+      "window.domAutomationController.send(linkScreenPositionY);",
+      &y));
+
+  gfx::Point point(x, y);
+  content::WindowedNotificationObserver observer(
+      chrome::NOTIFICATION_TAB_ADDED,
+      content::NotificationService::AllSources());
+  content::SimulateMouseClickAt(web_contents, 0,
+      blink::WebMouseEvent::ButtonMiddle, point);
+  observer.Wait();
+
+  int tab_count = browser()->tab_strip_model()->count();
+  ASSERT_EQ(2, tab_count);
+
+  const GURL& url =
+      browser()->tab_strip_model()->GetActiveWebContents()->GetURL();

[Lei Zhang, 2016/07/14 00:03:39]

Does GetActiveWebContents() still return the same pointer as |web_contents|
before?

If yes, then this implies the PDF page has navigated to example.com, which is
not right.
If not, then that's not right either because middle clicking should load the
link in a new tab, without changing the selected tab.

[jaepark, 2016/07/14 00:59:40]

Yes it does.
 
AFAIK, the url of the tab remains example.com even if it's actually navigated to
127.0.0.1 (I have checked this). 
Current ctrl + left click behavior is also opens a new tab and the new tab
becomes the active web content.
I know this is different from ctrl + left clicking (or middle clicking) link in
a normal web page. But if we want that behavior, I think it's better to do it in
another CL.

[Lei Zhang, 2016/07/14 01:25:04]

Sure. Can you add a comment to here to note the existing behavior is wrong and
reference https://crbug.com/628054 ?

+  ASSERT_EQ(std::string("http://www.example.com/"), url.spec());
+}