Open hyperlinks in PDF in a new tab when middle mouse clicking.

pdf/pdfium/pdfium_page.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_page.h"
 
 #include <math.h>
 #include <stddef.h>
 
 #include <algorithm>
@@ skipping 353 matching lines @@
       if (rect.Contains(origin)) {
         if (target)
           target->url = links_[i].url;
         return i;
       }
     }
   }
   return -1;
 }
 
+std::vector<pp::Rect> PDFiumPage::GetLinkRects() {
+  if (!available_)
+    return std::vector<pp::Rect>();
+
+  CalculateLinks();
+
+  std::vector<pp::Rect> link_rects;
+  for (size_t i = 0; i < links_.size(); ++i) {

[Lei Zhang, 2016/07/08 18:02:36]

nit: You can also do a range-based for loop here.

[jaepark, 2016/07/08 20:58:16]

Done.

+    pp::Rect rect = UnionLinkCharRects(links_[i].rects);

[Lei Zhang, 2016/07/08 18:02:36]

nit: No need for |rect| ?

[jaepark, 2016/07/08 20:58:16]

Done.

+    link_rects.push_back(rect);
+  }
+
+  return link_rects;
+}
+
+pp::Rect PDFiumPage::UnionLinkCharRects(const std::vector<pp::Rect> rects) {
+  if (rects.empty())

[Lei Zhang, 2016/07/08 18:02:36]

Can't you skip this check and get the same result?

[jaepark, 2016/07/08 20:58:16]

Done.

+    return pp::Rect();
+
+  pp::Rect result_rect;
+  for (const auto& rect : rects)
+    result_rect = result_rect.Union(rect);
+
+  return result_rect;
+}
+
 std::vector<int> PDFiumPage::GetLinks(pp::Rect text_area,
                                       std::vector<LinkTarget>* targets) {
   std::vector<int> links;
   if (!available_)
     return links;
 
   CalculateLinks();
 
   for (size_t i = 0; i < links_.size(); ++i) {
     for (const auto& rect : links_[i].rects) {
@@ skipping 113 matching lines @@
   page_->loading_count_--;
 }
 
 PDFiumPage::Link::Link() {
 }
 
 PDFiumPage::Link::~Link() {
 }
 
 }  // namespace chrome_pdf