chrome/browser/android/contextualsearch/contextual_search_delegate.cc - Issue 2127373006: Use base::StartWith() in more places when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/contextualsearch/contextual_search_delegate.cc

Issue 2127373006: Use base::StartWith() in more places when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc » ('j') | chrome/browser/devtools/device/adb/mock_adb_server.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/contextualsearch/contextual_search_delegate.cc

diff --git a/chrome/browser/android/contextualsearch/contextual_search_delegate.cc b/chrome/browser/android/contextualsearch/contextual_search_delegate.cc

index c4048e61a0eb6442a3c39abee759e2c4e72cce84..9386a2430909eb6153f7b1891b12c200127efd6f 100644

--- a/chrome/browser/android/contextualsearch/contextual_search_delegate.cc

+++ b/chrome/browser/android/contextualsearch/contextual_search_delegate.cc

@@ -427,7 +427,8 @@ void ContextualSearchDelegate::DecodeSearchTermFromJsonResponse(

int* mention_start,

int* mention_end,

std::string* lang) {

- bool contains_xssi_escape = response.find(kXssiEscape) == 0;

+ bool contains_xssi_escape =

+ base::StartsWith(response, kXssiEscape, base::CompareCase::SENSITIVE);

const std::string& proper_json =

contains_xssi_escape ? response.substr(strlen(kXssiEscape)) : response;

JSONStringValueDeserializer deserializer(proper_json);