Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5867)

Unified Diff: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc

Issue 2127373006: Use base::StartWith() in more places when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, resolve conflict Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
diff --git a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
index 1ebf97c0e200cae672b4559ef0039f1f81f7b21a..23f17aaf6afbc94aa8ef6951dfe984946b433a95 100644
--- a/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
+++ b/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
@@ -10,6 +10,7 @@
#include <string>
#include "base/logging.h"
+#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/grit/generated_resources.h"
@@ -488,9 +489,12 @@ bool IsPlatformAppSafeForPublicSession(const extensions::Extension* extension) {
}
// Allow arbitrary web requests. Don't include <all_urls> because that
// also matches file:// schemes.
- if (permission_string.find("https://") == 0 ||
- permission_string.find("http://") == 0 ||
- permission_string.find("ftp://") == 0) {
+ if (base::StartsWith(permission_string, "https://",
+ base::CompareCase::SENSITIVE) ||
+ base::StartsWith(permission_string, "http://",
+ base::CompareCase::SENSITIVE) ||
+ base::StartsWith(permission_string, "ftp://",
+ base::CompareCase::SENSITIVE)) {
continue;
}
LOG(ERROR) << extension->id()

Powered by Google App Engine
This is Rietveld 408576698