Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2127373005: Fix RetriableHttp (Closed)

Created:
4 years, 5 months ago by tnn
Modified:
4 years, 5 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix RetriableHttp #

Patch Set 3 : Fix RetriableHttp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M infra_libs/httplib2_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M infra_libs/test/httplib2_utils_test.py View 1 1 chunk +7 lines, -0 lines 0 comments Download
M infra_libs/ts_mon/common/monitors.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M infra_libs/ts_mon/common/test/monitors_test.py View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tnn
I've also confirmed that, if we remove 'request', the test will fail with "instancemethod cannot ...
4 years, 5 months ago (2016-07-08 19:00:45 UTC) #1
Sergey Berezin
-@google, +@chromium.org LGTM, thanks! That was subtle :-) Can we have a regression test for ...
4 years, 5 months ago (2016-07-08 19:16:08 UTC) #3
tnn
On 2016/07/08 19:16:08, Sergey Berezin wrote: > -@google, mailto:+@chromium.org > > LGTM, thanks! That was ...
4 years, 5 months ago (2016-07-08 19:37:56 UTC) #4
Sergey Berezin
thanks! LGTM
4 years, 5 months ago (2016-07-08 20:38:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127373005/40001
4 years, 5 months ago (2016-07-08 20:47:31 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 21:02:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/36b9234bed528104780967e31dd49...

Powered by Google App Engine
This is Rietveld 408576698