Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 2127343003: Rename MockTool -> MockWebKitPatch. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename MockTool -> MockWebKitPatch. Now that webkit_patch and multi_command_tool are merged, (http://crbug.com/621181) it may be confusing that the mock version of WebKitPatch is called MockTool. This renaming also resolves a FIXME comment. BUG=621181 Committed: https://crrev.com/a2414e189b421e4a8f2998bee6ce3231e432eb21 Cr-Commit-Position: refs/heads/master@{#407634}

Patch Set 1 #

Patch Set 2 : Rename MockTool -> MockWebKitPatch. #

Patch Set 3 : Rebased #

Messages

Total messages: 19 (13 generated)
qyearsley
4 years, 5 months ago (2016-07-08 18:03:56 UTC) #2
qyearsley
Ping - this is a non-urgent but relatively small CL.
4 years, 5 months ago (2016-07-25 20:44:04 UTC) #13
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-25 21:58:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127343003/40001
4 years, 5 months ago (2016-07-25 22:32:04 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-25 23:39:44 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 23:41:49 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a2414e189b421e4a8f2998bee6ce3231e432eb21
Cr-Commit-Position: refs/heads/master@{#407634}

Powered by Google App Engine
This is Rietveld 408576698