Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 2127313002: Revert of Link to DirectWrite directly, instead of calling LoadLibrary (Closed)

Created:
4 years, 5 months ago by Ilya Kulshin
Modified:
4 years, 5 months ago
Reviewers:
jam, scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Link to DirectWrite directly, instead of calling LoadLibrary (patchset #4 id:290001 of https://codereview.chromium.org/2111373002/ ) Reason for revert: Breaks https://build.chromium.org/p/chromium.win/builders/Win8%20GYP/builds/430 Original issue's description: > Reland of Link to DirectWrite directly, instead of calling LoadLibrary (patchset #1 id:1 of https://codereview.chromium.org/2117683002/ ) > > Reason for revert: > Attempting to reland original change. > > Original issue's description: > > Revert of Link to DirectWrite directly, instead of calling LoadLibrary (patchset #8 id:180001 of https://codereview.chromium.org/2029343002/ ) > > > > Reason for revert: > > Breaks aura_demo target > > > > Original issue's description: > > > Link to DirectWrite directly, instead of calling LoadLibrary > > > > > > BUG= > > > > > > Committed: https://crrev.com/7561063aa78a31c73506f666c9eeccf45fe3dc07 > > > Cr-Commit-Position: refs/heads/master@{#403344} > > > > TBR=scottmg@chromium.org,jam@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG= > > > > Committed: https://crrev.com/d825ab07a72e8440c0d1b77464eef5d8740a7258 > > Cr-Commit-Position: refs/heads/master@{#403379} > > BUG= > TBR=jam@chromium.org > > Committed: https://crrev.com/ceb58c4b801e325292f37d3a60b9378ac92a6955 > Cr-Commit-Position: refs/heads/master@{#404268} TBR=scottmg@chromium.org,jam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/4a1eba3116f1cbc409b83aac547c52778d89bcb3 Cr-Commit-Position: refs/heads/master@{#404278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -59 lines) Patch
M content/child/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc View 1 chunk +23 lines, -3 lines 0 comments Download
M content/child/dwrite_font_proxy/dwrite_font_proxy_win_unittest.cc View 13 chunks +42 lines, -2 lines 0 comments Download
M content/child/dwrite_font_proxy/font_fallback_win_unittest.cc View 2 chunks +17 lines, -2 lines 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -9 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/aura.gyp View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M ui/gfx/font_fallback_win.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/gfx/gfx_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/win/direct_write.cc View 1 chunk +16 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ilya Kulshin
Created Revert of Link to DirectWrite directly, instead of calling LoadLibrary
4 years, 5 months ago (2016-07-08 00:37:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127313002/1
4 years, 5 months ago (2016-07-08 00:37:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 00:39:09 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4a1eba3116f1cbc409b83aac547c52778d89bcb3 Cr-Commit-Position: refs/heads/master@{#404278}
4 years, 5 months ago (2016-07-08 00:41:20 UTC) #6
Ilya Kulshin
4 years, 5 months ago (2016-07-08 00:42:40 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2134533002/ by kulshin@chromium.org.

The reason for reverting is: Attempting, yet again, to reland the original
change..

Powered by Google App Engine
This is Rietveld 408576698