Issue 2127273002: VM: Move inlining of _bitAndFromSmi to the flow graph inliner.

Issue 2127273002: VM: Move inlining of _bitAndFromSmi to the flow graph inliner. (Closed)

Created:
4 years, 5 months ago by Florian Schneider

Modified:
4 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Move inlining of _bitAndFromSmi to the flow graph inliner. Also move the check for number of checks to a common place when replacing recognized methods in the optimizer. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/c09e9ffc91809d4c297f0793242d2a903950952e

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -39 lines)			Patch
M	runtime/vm/aot_optimizer.cc	View	1 2	5 chunks	+11 lines, -14 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View		2 chunks	+25 lines, -0 lines	0 comments	Download
M	runtime/vm/jit_optimizer.cc	View	1 2	5 chunks	+10 lines, -25 lines	0 comments	Download

Total messages: 6 (2 generated)

Florian Schneider

I'd like to get rid of NumberOfUsedChecks -- not sure where we actually benefit from ...

4 years, 5 months ago (2016-07-07 22:12:08 UTC) #2

Florian Schneider

4 years, 5 months ago (2016-07-12 21:06:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
c09e9ffc91809d4c297f0793242d2a903950952e (presubmit successful).