Keep the SystemModalContainerEventHandler added

components/exo/pointer_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/shell_window_ids.h"
+#include "ash/common/wm_shell.h"
 #include "ash/shell.h"
+#include "ash/wm/window_util.h"
 #include "components/exo/buffer.h"
 #include "components/exo/pointer.h"
 #include "components/exo/pointer_delegate.h"
 #include "components/exo/shell_surface.h"
 #include "components/exo/surface.h"
 #include "components/exo/test/exo_test_base.h"
 #include "components/exo/test/exo_test_helper.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "ui/events/event_utils.h"
 #include "ui/events/test/event_generator.h"
@@ skipping 265 matching lines @@
   generator.MoveMouseTo(surface->window()->GetBoundsInScreen().origin());
 
   EXPECT_CALL(delegate,
               OnPointerScroll(testing::_, gfx::Vector2dF(1, 1), true));
   generator.MoveMouseWheel(1, 1);
 
   EXPECT_CALL(delegate, OnPointerDestroying(pointer.get()));
   pointer.reset();
 }
 
+TEST_F(PointerTest, IgnorePointerEventDuringModal) {
+  std::unique_ptr<Surface> surface(new Surface);
+  std::unique_ptr<ShellSurface> shell_surface(new ShellSurface(surface.get()));
+  std::unique_ptr<Buffer> buffer(
+      new Buffer(exo_test_helper()->CreateGpuMemoryBuffer(gfx::Size(10, 10))));
+  surface->Attach(buffer.get());
+  surface->Commit();
+  gfx::Point location = surface->window()->GetBoundsInScreen().origin();
+
+  MockPointerDelegate delegate;
+  std::unique_ptr<Pointer> pointer(new Pointer(&delegate));
+  ui::test::EventGenerator generator(ash::Shell::GetPrimaryRootWindow());
+
+  // Create surface for modal window.
+  std::unique_ptr<Surface> surface2(new Surface);
+  std::unique_ptr<ShellSurface> shell_surface2(
+      new ShellSurface(surface2.get(), nullptr, gfx::Rect(0, 0, 8, 8), true,
+                       ash::kShellWindowId_SystemModalContainer));
+  std::unique_ptr<Buffer> buffer2(
+      new Buffer(exo_test_helper()->CreateGpuMemoryBuffer(gfx::Size(8, 8))));
+  surface2->Attach(buffer2.get());
+  surface2->Commit();
+  ash::wm::CenterWindow(surface2->window());
+
+  // Open modal.

[oshima, 2016/07/07 22:01:18]

Make the windowmodal. (The window is already opened at this point)

+  shell_surface2->SetSystemModal(true);
+  EXPECT_TRUE(ash::WmShell::Get()->IsSystemModalWindowOpen());
+
+  // Check if pointer events on non-modal window are ignored.
+  EXPECT_CALL(delegate, CanAcceptPointerEventsForSurface(surface.get()))
+      .WillRepeatedly(testing::Return(true));
+  EXPECT_CALL(delegate, OnPointerEnter(surface.get(), gfx::PointF(), 0))
+      .Times(0);
+  EXPECT_CALL(delegate, OnPointerLeave(surface.get())).Times(0);
+  EXPECT_CALL(delegate, OnPointerMotion(testing::_, gfx::PointF(10, 10)))
+      .Times(0);
+  EXPECT_CALL(delegate,
+              OnPointerButton(testing::_, ui::EF_LEFT_MOUSE_BUTTON, true))
+      .Times(0);
+  EXPECT_CALL(delegate,
+              OnPointerButton(testing::_, ui::EF_LEFT_MOUSE_BUTTON, false))
+      .Times(0);
+  EXPECT_CALL(delegate, OnPointerScroll(testing::_, gfx::Vector2dF(1, 1), true))
+      .Times(0);
+  EXPECT_CALL(delegate,
+              OnPointerScroll(testing::_, gfx::Vector2dF(1, 1), false))
+      .Times(0);
+  EXPECT_CALL(delegate, OnPointerScrollCancel(testing::_)).Times(0);
+  EXPECT_CALL(delegate, OnPointerScrollStop(testing::_)).Times(0);
+  EXPECT_CALL(delegate, OnPointerFrame()).Times(0);

[oshima, 2016/07/07 22:01:17]

can you also test touch & gesture?

+
+  generator.MoveMouseTo(location);

[oshima, 2016/07/07 22:01:17]

can you group the event and expectation together , instead of mixing all?
something like

set expectation for mouse click
mouse click

set expectation for mouse wheel
mouse wheel

set expectation for touch
touch event

+  generator.ClickLeftButton();
+  generator.ScrollSequence(location, base::TimeDelta(), 1, 1, 1, 1);
+

[oshima, 2016/07/07 22:01:18]

can you also close the modal dialog and test if they receive events correctly?

+  EXPECT_CALL(delegate, OnPointerDestroying(pointer.get()));
+  pointer.reset();
+}
+
 }  // namespace
 }  // namespace exo