Added the framework for having canvas/recorder/picture record depth_set's.

tests/CanvasTest.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*  Description:
  *      This test defines a series of elementatry test steps that perform
  *      a single or a small group of canvas API calls. Each test step is
@@ skipping 760 matching lines @@
     canvas.restore();
     canvas.save();
     path.moveTo(5, 5);
     canvas.clipPath(path);
     canvas.restore();
     canvas.save();
     path.moveTo(7, 7);
     canvas.clipPath(path);  // should not assert here
     canvas.restore();
 }
 

[robertphillips, 2016/07/12 15:34:32]

This is kind of strange ...

[vjiaoblack, 2016/07/12 16:03:33]

Since we made getZ a protected method, I now know of no other way to access the
Z values to check if they're right with asserts.

+class SkTestCanvas : public SkCanvas {
+public:

[robertphillips, 2016/07/12 15:34:32]

If you want this to be a member function it should be named testUpdateDepth

[vjiaoblack, 2016/07/12 16:03:33]

Done.

+    void test_updatedepth(skiatest::Reporter* reporter) {

[robertphillips, 2016/07/12 15:34:32]

This comment shouldn't mention picture anymore

[vjiaoblack, 2016/07/12 16:03:33]

Done.

+        // set some depths (with picture enabled), then check them as they get set
+

[robertphillips, 2016/07/12 15:34:32]

If you want this to be a member function all the canvas methods need to be
preceeded with "this->"

[vjiaoblack, 2016/07/12 16:03:33]

Done.

+        REPORTER_ASSERT(reporter, getZ() == 0);
+        translateZ(-10);
+        REPORTER_ASSERT(reporter, getZ() == -10);
+
+        save();
+        translateZ(20);
+        REPORTER_ASSERT(reporter, getZ() == 10);
+
+        restore();
+        REPORTER_ASSERT(reporter, getZ() == -10);
+
+        translateZ(13.14);
+        REPORTER_ASSERT(reporter, SkScalarNearlyEqual(getZ(),3.14));
+    }
+};
+
 namespace {
 
 class MockFilterCanvas : public SkPaintFilterCanvas {
 public:
     MockFilterCanvas(SkCanvas* canvas) : INHERITED(canvas) { }
 
 protected:
     bool onFilter(SkTCopyOnFirstWrite<SkPaint>*, Type) const override { return true; }
 
 private:
@@ skipping 13 matching lines @@
     MockFilterCanvas filterCanvas(&canvas);
     REPORTER_ASSERT(reporter, canvas.getTotalMatrix() == filterCanvas.getTotalMatrix());
     REPORTER_ASSERT(reporter, canvas.getClipBounds(&clip1) == filterCanvas.getClipBounds(&clip2));
     REPORTER_ASSERT(reporter, clip1 == clip2);
 
     filterCanvas.clipRect(SkRect::MakeXYWH(30.5f, 30.7f, 100, 100));
     filterCanvas.scale(0.75f, 0.5f);
     REPORTER_ASSERT(reporter, canvas.getTotalMatrix() == filterCanvas.getTotalMatrix());
     REPORTER_ASSERT(reporter, canvas.getClipBounds(&clip1) == filterCanvas.getClipBounds(&clip2));
     REPORTER_ASSERT(reporter, clip1 == clip2);
+

[robertphillips, 2016/07/12 15:34:32]

Can you not just do:

{
   SkCanvas testCanvas(100, 100);

   test_updatedepth(reporter, &testCanvas);
}

and skip all the picture stuff and deriving an SkTestCanvas?

[vjiaoblack, 2016/07/12 16:03:33]

Uh. Oh.
pfft, right. 

I'll do that.

*tried to do it*

oh right, getZ() is protected. Can only do it from within the class.
(?)

+    SkPictureRecorder recorder;
+    SkTestCanvas* tCanvas;
+
+    tCanvas = (SkTestCanvas*) recorder.beginRecording(SkRect::MakeIWH(100, 100));
+    tCanvas->test_updatedepth(reporter);
+    recorder.finishRecordingAsPicture();
 }