Added the framework for having canvas/recorder/picture record depth_set's.

tests/CanvasTest.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*  Description:
  *      This test defines a series of elementatry test steps that perform
  *      a single or a small group of canvas API calls. Each test step is
@@ skipping 760 matching lines @@
     canvas.restore();
     canvas.save();
     path.moveTo(5, 5);
     canvas.clipPath(path);
     canvas.restore();
     canvas.save();
     path.moveTo(7, 7);
     canvas.clipPath(path);  // should not assert here
     canvas.restore();
 }
 

[robertphillips, 2016/07/11 19:24:52]

My suggestion here is to ditch the SkCanvasDrawDepthTester and just call
test_updatedepth passing in the reporter.

[vjiaoblack, 2016/07/11 19:48:13]

Done.

+class SkCanvasDrawDepthTester {
+public:

[robertphillips, 2016/07/11 19:24:53]

kCanvasWidth & kCanvasHeight

Also, these don't appear to be used anywhere.

[vjiaoblack, 2016/07/11 19:48:13]

Done.

+    const static int canvasWidth = 100;
+    const static int canvasHeight = 100;
+
+    SkCanvasDrawDepthTester(skiatest::Reporter* reporter) {

[robertphillips, 2016/07/11 19:24:53]

Don't need "this->" here

[vjiaoblack, 2016/07/11 19:48:13]

Done.

+        this->fReporter = reporter;
+    }
+
+    void runTests() {

[robertphillips, 2016/07/11 19:24:53]

testUpdateDepth. The '_' form is for static local methods.

Also, since testUpdateDepth isn't static you don't need to pass in fReporter.

[vjiaoblack, 2016/07/11 19:48:13]

Done.

+        this->test_updatedepth(this->fReporter);
+    }
+
+private:
+    skiatest::Reporter* fReporter;
+
+    void test_updatedepth(skiatest::Reporter* reporter) {

[robertphillips, 2016/07/11 19:24:52]

I don't know what recording into a picture is giving you in this test.

[vjiaoblack, 2016/07/11 19:48:13]

Done.

+        // set some depths (with picture enabled), then check them as they get set
+        SkPictureRecorder recorder;
+        SkCanvas* canvas;
+        sk_sp<SkPicture> picture;
+

[robertphillips, 2016/07/11 19:24:52]

You could use kCanvasWidth & kCanvasHeight here instead of 100, 100

[vjiaoblack, 2016/07/11 19:48:13]

Done.

+        canvas = recorder.beginRecording(SkRect::MakeIWH(100, 100));
+
+        canvas->setZ(-10);

[robertphillips, 2016/07/11 19:24:53]

REPORTER_ASSERT(reporter, canvas->getZ() == -10);

[vjiaoblack, 2016/07/11 19:48:13]

Done.

+        canvas->save();
+        canvas->setZ(10);
+        REPORTER_ASSERT(reporter, canvas->getZ() == 10);
+
+        canvas->restore();
+        REPORTER_ASSERT(reporter, canvas->getZ() == -10);
+
+        canvas->setZ(3.14);
+        REPORTER_ASSERT(reporter, canvas->getZ() == 3.14);
+
+        picture = recorder.finishRecordingAsPicture();
+    }
+};
+
 namespace {
 
 class MockFilterCanvas : public SkPaintFilterCanvas {
 public:
     MockFilterCanvas(SkCanvas* canvas) : INHERITED(canvas) { }
 
 protected:
     bool onFilter(SkTCopyOnFirstWrite<SkPaint>*, Type) const override { return true; }
 
 private:
@@ skipping 13 matching lines @@
     MockFilterCanvas filterCanvas(&canvas);
     REPORTER_ASSERT(reporter, canvas.getTotalMatrix() == filterCanvas.getTotalMatrix());
     REPORTER_ASSERT(reporter, canvas.getClipBounds(&clip1) == filterCanvas.getClipBounds(&clip2));
     REPORTER_ASSERT(reporter, clip1 == clip2);
 
     filterCanvas.clipRect(SkRect::MakeXYWH(30.5f, 30.7f, 100, 100));
     filterCanvas.scale(0.75f, 0.5f);
     REPORTER_ASSERT(reporter, canvas.getTotalMatrix() == filterCanvas.getTotalMatrix());
     REPORTER_ASSERT(reporter, canvas.getClipBounds(&clip1) == filterCanvas.getClipBounds(&clip2));
     REPORTER_ASSERT(reporter, clip1 == clip2);
+
+    SkCanvasDrawDepthTester depthTester(reporter);
+    depthTester.runTests();
 }