Added the framework for having canvas/recorder/picture record depth_set's.

tests/CanvasTest.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*  Description:
  *      This test defines a series of elementatry test steps that perform
  *      a single or a small group of canvas API calls. Each test step is
@@ skipping 761 matching lines @@
     canvas.save();
     path.moveTo(5, 5);
     canvas.clipPath(path);
     canvas.restore();
     canvas.save();
     path.moveTo(7, 7);
     canvas.clipPath(path);  // should not assert here
     canvas.restore();
 }
 
+class SkDrawDepthTester {
+public:

[robertphillips, 2016/07/11 18:39:35]

kCanvas* ?

[vjiaoblack, 2016/07/11 18:58:03]

Done.

+    const static int canvasWidth = 100;
+    const static int canvasHeight = 100;
+
+    SkDrawDepthTester(skiatest::Reporter* reporter) {

[robertphillips, 2016/07/11 18:39:35]

It doesn't look like you are saving off the reporter here

[vjiaoblack, 2016/07/11 18:58:03]

Done.

+    }
+
+    void runTests() {
+        this->test_updatedepth(this->_reporter);
+    }
+
+private:

[robertphillips, 2016/07/11 18:39:35]

Member variables are prefixed with 'f' not '_'

[vjiaoblack, 2016/07/11 18:58:03]

Done.

+    skiatest::Reporter* _reporter;
+

[robertphillips, 2016/07/11 18:39:35]

The SkPictureRecorder should just be on the stack in test_updatedepth

[vjiaoblack, 2016/07/11 18:58:03]

Done.

+    SkPictureRecorder _recorder;

[robertphillips, 2016/07/11 18:39:35]

Why do you need to store _canvas & _picture ?

[vjiaoblack, 2016/07/11 18:58:03]

Done.

+    sk_sp<SkPicture> _picture;
+    SkCanvas* _canvas;

[robertphillips, 2016/07/11 18:39:35]

Do you use paint at all ?

[vjiaoblack, 2016/07/11 18:58:03]

Done.

+    SkPaint paint;
+
+    void test_updatedepth(skiatest::Reporter* reporter) {
+        // set some depths (with picture enabled), then check them as they get set
+        this->_canvas = this->_recorder.beginRecording(SkRect::MakeIWH(100, 100));
+
+        this->_canvas->setZ(-10);
+        this->_canvas->save();
+        this->_canvas->setZ(10);
+        REPORTER_ASSERT(reporter, this->_canvas->getZ() == 10);
+
+        this->_canvas->restore();
+        REPORTER_ASSERT(reporter, this->_canvas->getZ() == -10);
+
+        this->_canvas->setZ(3.14);
+        REPORTER_ASSERT(reporter, this->_canvas->getZ() == 3.14);
+
+        this->_picture = this->_recorder.finishRecordingAsPicture();
+    }
+};
+
 namespace {
 
 class MockFilterCanvas : public SkPaintFilterCanvas {
 public:
     MockFilterCanvas(SkCanvas* canvas) : INHERITED(canvas) { }
 
 protected:
     bool onFilter(SkTCopyOnFirstWrite<SkPaint>*, Type) const override { return true; }
 
 private:
@@ skipping 13 matching lines @@
     MockFilterCanvas filterCanvas(&canvas);
     REPORTER_ASSERT(reporter, canvas.getTotalMatrix() == filterCanvas.getTotalMatrix());
     REPORTER_ASSERT(reporter, canvas.getClipBounds(&clip1) == filterCanvas.getClipBounds(&clip2));
     REPORTER_ASSERT(reporter, clip1 == clip2);
 
     filterCanvas.clipRect(SkRect::MakeXYWH(30.5f, 30.7f, 100, 100));
     filterCanvas.scale(0.75f, 0.5f);
     REPORTER_ASSERT(reporter, canvas.getTotalMatrix() == filterCanvas.getTotalMatrix());
     REPORTER_ASSERT(reporter, canvas.getClipBounds(&clip1) == filterCanvas.getClipBounds(&clip2));
     REPORTER_ASSERT(reporter, clip1 == clip2);
+
+    SkDrawDepthTester depthTester(reporter);
+    depthTester.runTests();
 }

[robertphillips, 2016/07/11 18:39:35]

What's with all these lines ?

[vjiaoblack, 2016/07/11 18:58:03]

Done.

+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+