Issue 212723003: MSan does not understand inline asm. This change preinitializes cpuid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212723003: MSan does not understand inline asm. This change preinitializes cpuid (Closed)

Created:
6 years, 9 months ago by eugenis

Modified:
6 years, 8 months ago

Reviewers:
danno, Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

MSan does not understand inline asm. This change preinitializes cpuid results, and disables the use of stos. Random mmap() addresses conflict with sanitizer memory layout. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20400

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -4 lines)			Patch
M	src/atomicops_internals_x86_gcc.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/platform-posix.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/v8utils.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

eugenis

On 2014/04/01 12:13:12, Jakob wrote: > LGTM, I'll land. Awesome, thanks!

6 years, 8 months ago (2014-04-01 12:28:00 UTC) #3

Jakob Kummerow

6 years, 8 months ago (2014-04-01 12:48:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r20400 (presubmit successful).