Avoid lossy effects of rounding by using contentBoxRect directly for plugin bounds.

Avoid lossy effects of rounding by using contentBoxRect directly for plugin bounds.

BUG=583470
TBR=mpearson

Committed: https://crrev.com/ba78b6f84a2cb06328bc610e2bfa45aa7bc35c12
Cr-Commit-Position: refs/heads/master@{#404432}

[chrishtr, 2016-07-07 17:55:17]

Description was changed from

==========
none


none


none


none


none

BUG=
==========

to

==========
Avoid lossy effects of rounding by using contentBoxRect directly for plugin
bounds.

BUG=583470
==========

[chrishtr, 2016-07-07 17:55:32]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@google.com

[Xianzhu, 2016-07-07 18:49:56]

wangxianzhu@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2016-07-07 18:49:57]

lgtm

https://codereview.chromium.org/2127213002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebPluginContainerImpl.cpp (right):

https://codereview.chromium.org/2127213002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebPluginContainerImpl.cpp:924: // TODO(chrishtr):
intentionally ignore transform, because the positioning of frameRect() does
also. This is probably wrong.
Nit: Remove the TODO.

[chrishtr, 2016-07-07 20:02:14]

https://codereview.chromium.org/2127213002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebPluginContainerImpl.cpp (right):

https://codereview.chromium.org/2127213002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebPluginContainerImpl.cpp:924: // TODO(chrishtr):
intentionally ignore transform, because the positioning of frameRect() does
also. This is probably wrong.
On 2016/07/07 at 18:49:57, Xianzhu wrote:
> Nit: Remove the TODO.

Done.

[chrishtr, 2016-07-07 20:02:19]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-07 20:02:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2127213002/#ps20001
(title: "none")

[commit-bot: I haz the power, 2016-07-07 20:03:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 21:03:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 21:03:15]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[chrishtr, 2016-07-08 16:20:38]

Description was changed from

==========
Avoid lossy effects of rounding by using contentBoxRect directly for plugin
bounds.

BUG=583470
==========

to

==========
Avoid lossy effects of rounding by using contentBoxRect directly for plugin
bounds.

BUG=583470
TBR=mpearson
==========

[chrishtr, 2016-07-08 16:20:44]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-08 16:20:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2127213002/#ps40001
(title: "none")

[commit-bot: I haz the power, 2016-07-08 16:21:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 17:48:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-08 17:48:59]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 17:49:59]

Description was changed from

==========
Avoid lossy effects of rounding by using contentBoxRect directly for plugin
bounds.

BUG=583470
TBR=mpearson
==========

to

==========
Avoid lossy effects of rounding by using contentBoxRect directly for plugin
bounds.

BUG=583470
TBR=mpearson

Committed: https://crrev.com/ba78b6f84a2cb06328bc610e2bfa45aa7bc35c12
Cr-Commit-Position: refs/heads/master@{#404432}
==========

[commit-bot: I haz the power, 2016-07-08 17:50:00]

Patchset 3 (id:??) landed as
https://crrev.com/ba78b6f84a2cb06328bc610e2bfa45aa7bc35c12
Cr-Commit-Position: refs/heads/master@{#404432}