chrome/browser/chooser_controller/chooser_controller.h - Issue 2127203002: Change WebBluetooth chooser OK button's label to be "Pair"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chooser_controller/chooser_controller.h

Issue 2127203002: Change WebBluetooth chooser OK button's label to be "Pair" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@support_chrome_extension_chooser_title

Patch Set: rebase and updated code Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chooser_controller/chooser_controller.h

diff --git a/chrome/browser/chooser_controller/chooser_controller.h b/chrome/browser/chooser_controller/chooser_controller.h

index 2982e0168804e4a383ec5a1099556191eea81534..b9ce21391b2880dbbddf08ed47b64892fb25dfaa 100644

--- a/chrome/browser/chooser_controller/chooser_controller.h

+++ b/chrome/browser/chooser_controller/chooser_controller.h

@@ -55,6 +55,9 @@ class ChooserController {

// Returns the text to be displayed in the chooser title.

base::string16 GetTitle();

+ // Returns the label for OK button.

+ virtual base::string16 GetOkButtonLabel() const;

Reilly Grant (use Gerrit) 2016/07/11 23:39:01 This function should be pure virtual.

juncai 2016/07/12 00:10:51 Done.

// The number of options users can pick from. For example, it can be

// the number of USB/Bluetooth device names which are listed in the

// chooser so that users can grant permission.

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/chooser_controller/chooser_controller.cc » ('j') | no next file with comments »