Change WebBluetooth chooser OK button's label to be "Pair"

Change WebBluetooth chooser OK button's label to be "Pair"

This is part 2 of matching WebBluetooth chooser views to mocks.

This CL changes WebBluetooth chooser OK button's label from "Connect"
to "Pair".

BUG=583452
Committed: https://crrev.com/3f5e325715ad94992d59718329ae3a93b03c97c1
Cr-Commit-Position: refs/heads/master@{#405042}

[juncai, 2016-07-11 23:30:32]

juncai@chromium.org changed reviewers:
+ msw@chromium.org, reillyg@chromium.org

[juncai, 2016-07-11 23:30:33]

msw@chromium.org: Please review changes in 
//chrome/browser/ui/

reillyg@chromium.org: Please review changes in 
//chrome/browser/chooser_controller/
//chrome/browser/usb/

[Reilly Grant (use Gerrit), 2016-07-11 23:39:01]

https://codereview.chromium.org/2127203002/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2127203002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:14881: +      <message
name="IDS_USB_DEVICE_CHOOSER_CONNECT_BUTTON_TEXT" desc="The text that is shown
on the connect button in the USB chooser popup.">
Some more descriptive messages for the translators:

Label on the button that closes the Bluetooth chooser popup and pairs the
selected device.
Label on the button that closes the USB chooser popup and connects the selected
device.
Label on the button that closes the chooser popup without selecting an option.

https://codereview.chromium.org/2127203002/diff/20001/chrome/browser/chooser_...
File chrome/browser/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/2127203002/diff/20001/chrome/browser/chooser_...
chrome/browser/chooser_controller/chooser_controller.h:59: virtual
base::string16 GetOkButtonLabel() const;
This function should be pure virtual.

[juncai, 2016-07-12 00:10:51]

https://codereview.chromium.org/2127203002/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2127203002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:14881: +      <message
name="IDS_USB_DEVICE_CHOOSER_CONNECT_BUTTON_TEXT" desc="The text that is shown
on the connect button in the USB chooser popup.">
On 2016/07/11 23:39:01, Reilly Grant wrote:
> Some more descriptive messages for the translators:
> 
> Label on the button that closes the Bluetooth chooser popup and pairs the
> selected device.
> Label on the button that closes the USB chooser popup and connects the
selected
> device.
> Label on the button that closes the chooser popup without selecting an option.

Done.

https://codereview.chromium.org/2127203002/diff/20001/chrome/browser/chooser_...
File chrome/browser/chooser_controller/chooser_controller.h (right):

https://codereview.chromium.org/2127203002/diff/20001/chrome/browser/chooser_...
chrome/browser/chooser_controller/chooser_controller.h:59: virtual
base::string16 GetOkButtonLabel() const;
On 2016/07/11 23:39:01, Reilly Grant wrote:
> This function should be pure virtual.

Done.

[Reilly Grant (use Gerrit), 2016-07-12 00:15:54]

lgtm

[msw, 2016-07-12 00:20:18]

lgtm

[juncai, 2016-07-13 04:33:41]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-07-13 04:33:41]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org,
reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2127203002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-13 04:34:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 05:21:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-13 05:21:39]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 05:22:50]

Description was changed from

==========
Change WebBluetooth chooser OK button's label to be "Pair"

This is part 2 of matching WebBluetooth chooser views to mocks.

This CL changes WebBluetooth chooser OK button's label from "Connect"
to "Pair".

BUG=583452
==========

to

==========
Change WebBluetooth chooser OK button's label to be "Pair"

This is part 2 of matching WebBluetooth chooser views to mocks.

This CL changes WebBluetooth chooser OK button's label from "Connect"
to "Pair".

BUG=583452

Committed: https://crrev.com/3f5e325715ad94992d59718329ae3a93b03c97c1
Cr-Commit-Position: refs/heads/master@{#405042}
==========

[commit-bot: I haz the power, 2016-07-13 05:22:50]

Patchset 4 (id:??) landed as
https://crrev.com/3f5e325715ad94992d59718329ae3a93b03c97c1
Cr-Commit-Position: refs/heads/master@{#405042}