Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2127183002: Add offsets to GrVkBuffer. (Closed)

Created:
4 years, 5 months ago by jvanverth1
Modified:
4 years, 5 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M src/gpu/vk/GrVkBuffer.h View 3 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/vk/GrVkBuffer.cpp View 4 chunks +8 lines, -5 lines 0 comments Download
M src/gpu/vk/GrVkCommandBuffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jvanverth1
4 years, 5 months ago (2016-07-07 17:08:24 UTC) #4
jvanverth1
Another baby step towards suballocating one large buffer into smaller ones.
4 years, 5 months ago (2016-07-07 17:09:00 UTC) #5
jvanverth1
Another baby step towards suballocating one large buffer into smaller ones.
4 years, 5 months ago (2016-07-07 17:09:01 UTC) #6
egdaniel
lgtm
4 years, 5 months ago (2016-07-07 17:16:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127183002/1
4 years, 5 months ago (2016-07-07 17:59:06 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 18:18:50 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/db37909347d034943bd6b0922710a94c6c6ea572

Powered by Google App Engine
This is Rietveld 408576698