Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2127163002: Limit PassiveDocumentEventListeners to touch and make it experimental (Closed)

Created:
4 years, 5 months ago by dtapuska
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit PassiveDocumentEventListeners to touch and make it experimental Make sure we don't change the default for wheel listeners for document elements so let the feature only work on touchstart and touchmove listeners. Enable it as experimental as well. BUG=625675 Committed: https://crrev.com/cba808f5a6b5b553da23c5612418ba6e8ce486a8 Cr-Commit-Position: refs/heads/master@{#404332}

Patch Set 1 #

Patch Set 2 : Fix layout tests #

Patch Set 3 : A few more layout tests #

Total comments: 11

Patch Set 4 : Make tests consistent #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-global.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects-iframe-doc.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/touch-event-cancelable.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/touch-target-move-documents.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 2 3 4 2 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/touch-event-handler.html View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
dtapuska
4 years, 5 months ago (2016-07-07 19:47:48 UTC) #3
Rick Byers
Just a couple small issues https://codereview.chromium.org/2127163002/diff/40001/third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.html File third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.html (right): https://codereview.chromium.org/2127163002/diff/40001/third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.html#newcode8 third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.html:8: content.addEventListener("touchstart", logEvent); any reason ...
4 years, 5 months ago (2016-07-07 20:02:09 UTC) #4
dtapuska
https://codereview.chromium.org/2127163002/diff/40001/third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.html File third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.html (right): https://codereview.chromium.org/2127163002/diff/40001/third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.html#newcode8 third_party/WebKit/LayoutTests/inspector-protocol/input/emulateTouchFromMouseEvent.html:8: content.addEventListener("touchstart", logEvent); On 2016/07/07 20:02:09, Rick Byers wrote: > ...
4 years, 5 months ago (2016-07-07 20:34:22 UTC) #5
Rick Byers
LGTM https://codereview.chromium.org/2127163002/diff/40001/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp File third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp (right): https://codereview.chromium.org/2127163002/diff/40001/third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp#newcode634 third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp:634: frameResource.complete("<body style='touch-action: none'></body>"); On 2016/07/07 20:34:22, dtapuska wrote: ...
4 years, 5 months ago (2016-07-07 20:45:01 UTC) #6
dtapuska
creis@chromium.org: Please review changes in One liner change to the change from yesterday in content/child/runtime_features.cc
4 years, 5 months ago (2016-07-07 20:47:12 UTC) #8
Charlie Reis
content/ LGTM
4 years, 5 months ago (2016-07-07 20:50:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127163002/60001
4 years, 5 months ago (2016-07-07 21:26:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-07 22:35:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127163002/60001
4 years, 5 months ago (2016-07-08 01:38:55 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/214075) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 5 months ago (2016-07-08 01:47:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127163002/80001
4 years, 5 months ago (2016-07-08 02:08:00 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-08 09:40:51 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 09:42:55 UTC) #24
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/cba808f5a6b5b553da23c5612418ba6e8ce486a8
Cr-Commit-Position: refs/heads/master@{#404332}

Powered by Google App Engine
This is Rietveld 408576698