Issue 2127143002: Integrate audible tab tracking into desktop engagement service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2127143002: Integrate audible tab tracking into desktop engagement service. (Closed)

Created:
4 years, 5 months ago by chrisha

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews, tfarina, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Integrate audible tab tracking into desktop engagement service. Patched from https://codereview.chromium.org/2118333002/#ps220001 BUG=

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+622 lines, -3 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download
A	chrome/browser/metrics/audible_contents_tracker.h	View	1 chunk	+75 lines, -0 lines	0 comments	Download
A	chrome/browser/metrics/audible_contents_tracker.cc	View	1 chunk	+76 lines, -0 lines	0 comments	Download
A	chrome/browser/metrics/chrome_visibility_observer.h	View	1 chunk	+40 lines, -0 lines	0 comments	Download
A	chrome/browser/metrics/chrome_visibility_observer.cc	View	1 chunk	+72 lines, -0 lines	0 comments	Download
A	chrome/browser/metrics/desktop_engagement_observer.h	View	1 chunk	+48 lines, -0 lines	0 comments	Download
A	chrome/browser/metrics/desktop_engagement_observer.cc	View	1 chunk	+60 lines, -0 lines	0 comments	Download
A	chrome/browser/metrics/desktop_engagement_service.h	View	1 chunk	+53 lines, -0 lines	0 comments	Download
A	chrome/browser/metrics/desktop_engagement_service.cc	View	1 chunk	+160 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_list.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_list.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_list_observer.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/tab_helpers.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

chrisha

4 years, 5 months ago (2016-07-13 18:38:41 UTC) #1

Closing this CL as work is being landed here:

https://codereview.chromium.org/2142983002/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages