Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 212713002: Revert of Fix dependencies for EventInterfaces.in (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Revert of Fix dependencies for EventInterfaces.in (https://codereview.chromium.org/209723002/) Reason for revert: This has broken android_aosp compilation. http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/58228 Original issue's description: > Fix dependencies for EventInterfaces.in > > EventInterfaces.in should depend on event IDL files. > It currently doesn't, which means it fails to rebuild correctly. > This fixes it. > > TBR=haraken > BUG=341748 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169998 TBR=haraken@chromium.org,acolwell@chromium.org,nbarth@chromium.org NOTREECHECKS=true NOTRY=true BUG=341748 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M Source/bindings/generated_bindings.gyp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/core_generated.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vsevik
Created Revert of Fix dependencies for EventInterfaces.in
6 years, 9 months ago (2014-03-26 11:30:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/212713002/1
6 years, 9 months ago (2014-03-26 11:30:10 UTC) #2
commit-bot: I haz the power
Change committed as 170044
6 years, 9 months ago (2014-03-26 11:30:34 UTC) #3
haraken
LGTM
6 years, 9 months ago (2014-03-26 11:31:44 UTC) #4
Nils Barth (inactive)
Thanks Vsevolod! How can we avoid this kind of breakage in future? Perhaps android_aosp should ...
6 years, 9 months ago (2014-03-27 06:49:50 UTC) #5
vsevik
6 years, 9 months ago (2014-03-27 08:21:00 UTC) #6
Message was sent while issue was closed.
On 2014/03/27 06:49:50, Nils Barth wrote:
> Thanks Vsevolod!
> How can we avoid this kind of breakage in future?
> Perhaps android_aosp should be tried for .gyp/.gypi changes?

It probably should. Unfortunately I don't even know what anroid_aosp bot is
doing, I was just sheriffing and it was broken.
You should better ask android guys about it.

Powered by Google App Engine
This is Rietveld 408576698