Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: src/objects.h

Issue 2127103002: [runtime] Move HasUnwindingInfoField of Code::flags to unused ICStateField. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 9671c9ba74e62530a026175e5a801d107eb8c595..b002a3c7c0a27d8c6eb349b0792c65b42a820482 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -5391,16 +5391,16 @@ class Code: public HeapObject {
class ProfilerTicksField : public BitField<int, 4, 28> {};
// Flags layout. BitField<type, shift, size>.
- class ICStateField : public BitField<InlineCacheState, 0, 3> {};
+ class ICStateField : public BitField<InlineCacheState, 0, 2> {};
+ class HasUnwindingInfoField : public BitField<bool, ICStateField::kNext, 1> {
+ };
class CacheHolderField
- : public BitField<CacheHolderFlag, ICStateField::kNext, 2> {};
+ : public BitField<CacheHolderFlag, HasUnwindingInfoField::kNext, 2> {};
class KindField : public BitField<Kind, CacheHolderField::kNext, 5> {};
STATIC_ASSERT(NUMBER_OF_KINDS <= KindField::kMax);
- class HasUnwindingInfoField : public BitField<bool, KindField::kNext, 1> {};
- class ExtraICStateField
- : public BitField<ExtraICState, HasUnwindingInfoField::kNext,
- PlatformSmiTagging::kSmiValueSize -
- HasUnwindingInfoField::kNext + 1> {};
+ class ExtraICStateField : public BitField<ExtraICState, KindField::kNext,
+ PlatformSmiTagging::kSmiValueSize -
+ KindField::kNext + 1> {};
// KindSpecificFlags1 layout (STUB, BUILTIN and OPTIMIZED_FUNCTION)
static const int kStackSlotsFirstBit = 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698