Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2127103002:
[runtime] Move HasUnwindingInfoField of Code::flags to unused ICStateField. (Closed)
|
Created:
4 years, 5 months ago by Igor Sheludko Modified:
4 years, 5 months ago Reviewers:
Toon Verwaest CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[runtime] Move HasUnwindingInfoField of Code::flags to unused ICStateField.
This should recover the regression caused by https://codereview.chromium.org/1993653003.
(Same sympthoms as in http://crbug/619016).
BUG=chromium:624309
Committed: https://crrev.com/3486bbc219d83a118770ae1aa579929b20cdba5d
Cr-Commit-Position: refs/heads/master@{#37587}
Patch Set 1 #
Messages
Total messages: 28 (19 generated)
Description was changed from ========== [runtime] Move HasUnwindingInfoField of Code::fkags to unused ICStateField. This is to recover the regression caused by https://codereview.chromium.org/1993653003. BUG=chromium:624309 ========== to ========== [runtime] Move HasUnwindingInfoField of Code::fkags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. BUG=chromium:624309 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ishell@chromium.org changed reviewers: + verwaest@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/8666) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/4588)
Patchset #1 (id:40001) has been deleted
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [runtime] Move HasUnwindingInfoField of Code::fkags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. BUG=chromium:624309 ========== to ========== [runtime] Move HasUnwindingInfoField of Code::fkags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in chromium:619016). BUG=chromium:624309 ==========
lgtm
Description was changed from ========== [runtime] Move HasUnwindingInfoField of Code::fkags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in chromium:619016). BUG=chromium:624309 ========== to ========== [runtime] Move HasUnwindingInfoField of Code::fkags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in crbug/619016). BUG=chromium:624309 ==========
Description was changed from ========== [runtime] Move HasUnwindingInfoField of Code::fkags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in crbug/619016). BUG=chromium:624309 ========== to ========== [runtime] Move HasUnwindingInfoField of Code::fkags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in https://crbug/619016). BUG=chromium:624309 ==========
Description was changed from ========== [runtime] Move HasUnwindingInfoField of Code::fkags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in https://crbug/619016). BUG=chromium:624309 ========== to ========== [runtime] Move HasUnwindingInfoField of Code::fkags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in http://crbug/619016). BUG=chromium:624309 ==========
The CQ bit was unchecked by ishell@chromium.org
The CQ bit was checked by ishell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ishell@chromium.org
Description was changed from ========== [runtime] Move HasUnwindingInfoField of Code::fkags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in http://crbug/619016). BUG=chromium:624309 ========== to ========== [runtime] Move HasUnwindingInfoField of Code::flags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in http://crbug/619016). BUG=chromium:624309 ==========
The CQ bit was checked by ishell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [runtime] Move HasUnwindingInfoField of Code::flags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in http://crbug/619016). BUG=chromium:624309 ========== to ========== [runtime] Move HasUnwindingInfoField of Code::flags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in http://crbug/619016). BUG=chromium:624309 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [runtime] Move HasUnwindingInfoField of Code::flags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in http://crbug/619016). BUG=chromium:624309 ========== to ========== [runtime] Move HasUnwindingInfoField of Code::flags to unused ICStateField. This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in http://crbug/619016). BUG=chromium:624309 Committed: https://crrev.com/3486bbc219d83a118770ae1aa579929b20cdba5d Cr-Commit-Position: refs/heads/master@{#37587} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3486bbc219d83a118770ae1aa579929b20cdba5d Cr-Commit-Position: refs/heads/master@{#37587} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
