Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2127063003:
Avoid the use of foreach on NodeList. (Closed)
|
Created:
4 years, 5 months ago by David Tseng Modified:
4 years, 5 months ago Reviewers:
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAvoid the use of foreach on NodeList.
Even though Chrome now supports foreach on NodeList (which is now iterable), we should do this because:
- Dartium is behind
- some users don't upgrade Chrome regularly
- failing here causes total silence while within web content
Originally introduced by
crrev.com/2074513002/
BUG=626325
TBR=dmazzoni@chromium.org
Committed: https://crrev.com/2b13ada6ab99d14d012e77f7a2885c44789c6b08
Cr-Commit-Position: refs/heads/master@{#405873}
Patch Set 1 #
Messages
Total messages: 17 (12 generated)
Description was changed from ========== Avoid the use of foreach on NodeList. ========== to ========== Avoid the use of foreach on NodeList. Even though Chrome now supports foreach on NodeList (which is now iterable), we should do this because: - Dartium is behind - some users don't upgrade Chrome regularly - failing here causes total silence while within web content BUG=626325 ==========
dtseng@chromium.org changed reviewers: + dmazzoni@chromium.org
dtseng@chromium.org changed reviewers: + aboxhall@chromium.org - dmazzoni@chromium.org
Description was changed from ========== Avoid the use of foreach on NodeList. Even though Chrome now supports foreach on NodeList (which is now iterable), we should do this because: - Dartium is behind - some users don't upgrade Chrome regularly - failing here causes total silence while within web content BUG=626325 ========== to ========== Avoid the use of foreach on NodeList. Even though Chrome now supports foreach on NodeList (which is now iterable), we should do this because: - Dartium is behind - some users don't upgrade Chrome regularly - failing here causes total silence while within web content Originally introduced by crrev.com/2074513002/ BUG=626325 TBR=dmazzoni@chromium.org ==========
dtseng@chromium.org changed reviewers: - aboxhall@chromium.org
The CQ bit was checked by dtseng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dtseng@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Avoid the use of foreach on NodeList. Even though Chrome now supports foreach on NodeList (which is now iterable), we should do this because: - Dartium is behind - some users don't upgrade Chrome regularly - failing here causes total silence while within web content Originally introduced by crrev.com/2074513002/ BUG=626325 TBR=dmazzoni@chromium.org ========== to ========== Avoid the use of foreach on NodeList. Even though Chrome now supports foreach on NodeList (which is now iterable), we should do this because: - Dartium is behind - some users don't upgrade Chrome regularly - failing here causes total silence while within web content Originally introduced by crrev.com/2074513002/ BUG=626325 TBR=dmazzoni@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Avoid the use of foreach on NodeList. Even though Chrome now supports foreach on NodeList (which is now iterable), we should do this because: - Dartium is behind - some users don't upgrade Chrome regularly - failing here causes total silence while within web content Originally introduced by crrev.com/2074513002/ BUG=626325 TBR=dmazzoni@chromium.org ========== to ========== Avoid the use of foreach on NodeList. Even though Chrome now supports foreach on NodeList (which is now iterable), we should do this because: - Dartium is behind - some users don't upgrade Chrome regularly - failing here causes total silence while within web content Originally introduced by crrev.com/2074513002/ BUG=626325 TBR=dmazzoni@chromium.org Committed: https://crrev.com/2b13ada6ab99d14d012e77f7a2885c44789c6b08 Cr-Commit-Position: refs/heads/master@{#405873} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2b13ada6ab99d14d012e77f7a2885c44789c6b08 Cr-Commit-Position: refs/heads/master@{#405873} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
