Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2127053002: Revert of Fix inspector overlay when use-zoom-for-dsf is enabled. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
dgozman, Bret, oshima, bokan
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix inspector overlay when use-zoom-for-dsf is enabled. (patchset #8 id:140001 of https://codereview.chromium.org/2108803006/ ) Reason for revert: inspector/elements/shadow/elements-panel-shadow-selection-on-refresh-1.html is crashy after this change. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Felements%2Fshadow%2Felements-panel-shadow-selection-on-refresh-1.html Original issue's description: > Fix inspector overlay when use-zoom-for-dsf is enabled. > > Inspector overlays were misaligned because the path points were drawing > in window coordinates and needed to be scaled to viewport coordinates. > Should be no change when use-zoom-for-dsf is off. > > BUG=622862 > > Committed: https://crrev.com/6651b97ebd509e97bea8929303738dc20a3ed880 > Cr-Commit-Position: refs/heads/master@{#404063} TBR=dgozman@chromium.org,oshima@chromium.org,bokan@chromium.org,bsep@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622862 Committed: https://crrev.com/9a427768ddb6797924f968113b78491feecf95cd Cr-Commit-Position: refs/heads/master@{#404093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -31 lines) Patch
M content/renderer/devtools/devtools_agent.cc View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp View 8 chunks +10 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 4 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tkent
Created Revert of Fix inspector overlay when use-zoom-for-dsf is enabled.
4 years, 5 months ago (2016-07-07 06:48:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127053002/1
4 years, 5 months ago (2016-07-07 06:49:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 06:49:46 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 06:49:51 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 06:51:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a427768ddb6797924f968113b78491feecf95cd
Cr-Commit-Position: refs/heads/master@{#404093}

Powered by Google App Engine
This is Rietveld 408576698