Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: content/renderer/render_view_impl.cc

Issue 212703005: Preserve Page::openedByDOM state across process swaps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tie opened_by_dom with opener. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 692575e6acb82821e8c3d28b8c13cb7a9afb5920..d85553a7fbdc2797e599155adf1f82b1d561c359 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -792,6 +792,9 @@ void RenderViewImpl::Initialize(RenderViewImplParams* params) {
if (!params->frame_name.empty())
webview()->mainFrame()->setName(params->frame_name);
+ if (params->created_with_opener)
+ webview()->setOpenedByDOM();
Charlie Reis 2014/04/05 01:41:25 Let's put a TODO to move this state from Blink int
davidben 2014/04/07 17:57:52 Done.
+
OnSetRendererPrefs(params->renderer_prefs);
#if defined(ENABLE_WEBRTC)
@@ -925,6 +928,7 @@ RenderViewImpl* RenderViewImpl::Create(
bool is_renderer_created,
bool swapped_out,
bool hidden,
+ bool created_with_opener,
int32 next_page_id,
const blink::WebScreenInfo& screen_info,
AccessibilityMode accessibility_mode) {
@@ -940,6 +944,7 @@ RenderViewImpl* RenderViewImpl::Create(
is_renderer_created,
swapped_out,
hidden,
+ created_with_opener,
next_page_id,
screen_info,
accessibility_mode);
@@ -1574,6 +1579,7 @@ WebView* RenderViewImpl::createView(
true, // is_renderer_created
false, // swapped_out
params.disposition == NEW_BACKGROUND_TAB, // hidden
+ true, // created_with_opener
1, // next_page_id
screen_info_,
accessibility_mode_);

Powered by Google App Engine
This is Rietveld 408576698