Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Unified Diff: content/renderer/render_view_impl.h

Issue 212703005: Preserve Page::openedByDOM state across process swaps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: creis comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index 1244c888e07f836f35dfad0cd0d3889e706f5d13..e491557e025248d38aa1d466c9527495bfa452f5 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -181,8 +181,11 @@ class CONTENT_EXPORT RenderViewImpl
public base::SupportsWeakPtr<RenderViewImpl> {
public:
// Creates a new RenderView. |opener_id| is the routing ID of the RenderView
- // responsible for creating this RenderView.
+ // responsible for creating this RenderView. Note that if the original opener
+ // has been closed, |window_was_created_with_opener| while be true while
nasko 2014/04/08 22:43:25 nit: This sentence doesn't read very easily and I'
davidben 2014/04/08 23:48:23 It means I'm very bad at typing. :-) Fixed.
+ // |opened_id| is MSG_ROUTING_NONE.
static RenderViewImpl* Create(int32 opener_id,
+ bool window_was_created_with_opener,
const RendererPreferences& renderer_prefs,
const WebPreferences& webkit_prefs,
int32 routing_id,

Powered by Google App Engine
This is Rietveld 408576698