Preserve Page::openedByDOM state across process swaps.

content/renderer/render_view_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 163 matching lines @@
 class CONTENT_EXPORT RenderViewImpl
     : public RenderWidget,
       NON_EXPORTED_BASE(public blink::WebViewClient),
       NON_EXPORTED_BASE(public blink::WebFrameClient),
       NON_EXPORTED_BASE(public blink::WebPageSerializerClient),
       public RenderView,
       NON_EXPORTED_BASE(public WebMediaPlayerDelegate),
       public base::SupportsWeakPtr<RenderViewImpl> {
  public:
   // Creates a new RenderView. |opener_id| is the routing ID of the RenderView
   // responsible for creating this RenderView.

[Charlie Reis, 2014/04/05 01:41:25]

Worth pointing out that |created_with_opener| can be true when |opener_id| is
MSG_ROUTING_NONE, if the opener has been closed by the time this view is
created.

(That fact does make the name a bit confusing.  I wonder if we want to switch
over to something like window_created_with_opener around this point in the
stack.)

[davidben, 2014/04/07 17:57:52]

Done.

   static RenderViewImpl* Create(int32 opener_id,
                                 const RendererPreferences& renderer_prefs,
                                 const WebPreferences& webkit_prefs,
                                 int32 routing_id,
                                 int32 main_frame_routing_id,
                                 int32 surface_id,
                                 int64 session_storage_namespace_id,
                                 const base::string16& frame_name,
                                 bool is_renderer_created,
                                 bool swapped_out,
                                 bool hidden,
+                                bool created_with_opener,

[Charlie Reis, 2014/04/05 01:41:25]

This should probably be up near opener_id.

[davidben, 2014/04/07 17:57:52]

Done.

                                 int32 next_page_id,
                                 const blink::WebScreenInfo& screen_info,
                                 AccessibilityMode accessibility_mode);
 
   // Used by content_layouttest_support to hook into the creation of
   // RenderViewImpls.
   static void InstallCreateHook(
       RenderViewImpl* (*create_render_view_impl)(RenderViewImplParams*));
 
   // Returns the RenderViewImpl containing the given WebView.
@@ skipping 1210 matching lines @@
   // use the Observer interface to filter IPC messages and receive frame change
   // notifications.
   // ---------------------------------------------------------------------------
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_