Preserve Page::openedByDOM state across process swaps.

content/public/browser/web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 438 matching lines @@
   virtual void DidEndColorChooser() = 0;
 
   // Returns true if the location bar should be focused by default rather than
   // the page contents. The view calls this function when the tab is focused
   // to see what it should do.
   virtual bool FocusLocationBarByDefault() = 0;
 
   // Does this have an opener associated with it?
   virtual bool HasOpener() const = 0;
 
+  // True if this WebContents was created with an opener. HasOpener() becomes
+  // calls if the opener is closed while this remains true. (Relevant for
+  // whether window.close() is allowed.)

[Charlie Reis, 2014/04/05 01:41:25]

I'm having trouble reading this.  s/calls/false/?

I think both this and HasOpener could probably be rephrased to be clearer:

// Returns whether this WebContents currently has an opener WebContents.
HasOpener()...

// Returns whether this WebContents had an opener WebContents when it was
created.  This affects whether window.close() is allowed.
CreatedWithOpener() ...

[davidben, 2014/04/07 17:57:52]

Removed the additional method for now since we're splitting prerender out.

+  virtual bool CreatedWithOpener() const = 0;
+
   typedef base::Callback<void(
       int, /* id */
       int, /* HTTP status code */
       const GURL&, /* image_url */
       const std::vector<SkBitmap>&, /* bitmaps */
       /* The sizes in pixel of the bitmaps before they were resized due to the
          max bitmap size passed to DownloadImage(). Each entry in the bitmaps
          vector corresponds to an entry in the sizes vector. If a bitmap was
          resized, there should be a single returned bitmap. */
       const std::vector<gfx::Size>&)>
@@ skipping 39 matching lines @@
 
  private:
   // This interface should only be implemented inside content.
   friend class WebContentsImpl;
   WebContents() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_