Preserve Page::openedByDOM state across process swaps.

content/browser/renderer_host/render_view_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 230 matching lines @@
   }
 
   // Set up the RenderView child process. Virtual because it is overridden by
   // TestRenderViewHost. If the |frame_name| parameter is non-empty, it is used
   // as the name of the new top-level frame.
   // The |opener_route_id| parameter indicates which RenderView created this
   // (MSG_ROUTING_NONE if none). If |max_page_id| is larger than -1, the
   // RenderView is told to start issuing page IDs at |max_page_id| + 1.
   virtual bool CreateRenderView(const base::string16& frame_name,
                                 int opener_route_id,
-                                int32 max_page_id);
+                                int32 max_page_id,
+                                bool created_with_opener);

[Charlie Reis, 2014/04/05 01:41:25]

Please document this parameter above.

I agree that this adds some work for us in removing RenderView, but we haven't
starting collecting the cache of page-level state yet in the renderer process. 
(Nasko, were we talking about putting that cached data on the top-level
RenderFrame?  I think some separate PageContext class might be cleaner.)

Anyway, we can add it here for now.

[davidben, 2014/04/07 17:57:52]

Done. I can also do the PageContext thing if those plans are concrete enough
that there's a place to add it that would be useful.

[nasko, 2014/04/08 22:43:25]

I don't think we have clear enough plan for page-level context in the renderer
process. On the browser side, it should be on WebContentsImpl.
It should be fine to add the new param for now, since we aren't close to
removing RenderView and this will be needed even after we remove it.

 
   base::TerminationStatus render_view_termination_status() const {
     return render_view_termination_status_;
   }
 
   // Returns the content specific prefs for this RenderViewHost.
   WebPreferences GetWebkitPrefs(const GURL& url);
 
   // Sends the given navigation message. Use this rather than sending it
   // yourself since this does the internal bookkeeping described below. This
@@ skipping 445 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
 };
 
 #if defined(COMPILER_MSVC)
 #pragma warning(pop)
 #endif
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_