Preserve Page::openedByDOM state across process swaps.

chrome/browser/prerender/prerender_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prerender/prerender_manager.h"
 
 #include <algorithm>
 #include <functional>
 #include <string>
 #include <vector>
@@ skipping 511 matching lines @@
     // there is a pending entry, it may not commit.
     // TODO(creis): If there is a pending navigation and no last committed
     // entry, we might be able to transfer the network request instead.
     if (!new_web_contents->GetController().CanPruneAllButLastCommitted()) {
       // Abort this prerender so it is not used later. http://crbug.com/292121
       prerender_data->contents()->Destroy(FINAL_STATUS_NAVIGATION_UNCOMMITTED);
       return NULL;
     }
   }
 
-  // Do not use the prerendered version if there is an opener object.
-  if (web_contents->HasOpener()) {
+  // Do not use the prerendered version if the target WebContents has an opener
+  // or was created with one. The latter controls whether window.close() is
+  // allowed, so the behavior is observable.
+  if (web_contents->CreatedWithOpener()) {

[Charlie Reis, 2014/04/05 01:41:25]

Unfortunately, using the opener for this was the wrong thing in the first place.
 I mentioned this to cbentzel in http://crbug.com/118294 but I think it got
forgotten.

Prerendering should never be used in tabs with other views in the same
SiteInstance.  Otherwise there are same-origin windows with a reference to the
current tab that will break when it moves to the prerendered process.  The
opener is not the right way to detect this, since it doesn't apply for the
opener itself.

Let's move that fix to a different CL.

[davidben, 2014/04/07 17:57:52]

Hrm, yeah, I'd been wondering if the opener check was a little too lax...

Moving prerender bits out. Also unexposing CreatedWithOpener() outside of
content/ for now. If we end up doing the prerender thing per 118294, it might
not be needed anyway.

     prerender_data->contents()->Destroy(FINAL_STATUS_WINDOW_OPENER);
     return NULL;
   }
 
   // Do not swap in the prerender if the current WebContents is being captured.
   if (web_contents->GetCapturerCount() > 0) {
     prerender_data->contents()->Destroy(FINAL_STATUS_PAGE_BEING_CAPTURED);
     return NULL;
   }
 
@@ skipping 1279 matching lines @@
   histograms_->RecordNetworkBytes(used, prerender_bytes, recent_profile_bytes);
 }
 
 void PrerenderManager::AddProfileNetworkBytesIfEnabled(int64 bytes) {
   DCHECK_GE(bytes, 0);
   if (IsEnabled() && ActuallyPrerendering())
     profile_network_bytes_ += bytes;
 }
 
 }  // namespace prerender