Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: src/arm64/lithium-arm64.h

Issue 212703002: Consistently use a separate Lithium instruction for flooring division. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added TODOs Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1306 matching lines...) Expand 10 before | Expand all | Expand 10 after
1317 DECLARE_CONCRETE_INSTRUCTION(DivByConstI, "div-by-const-i") 1317 DECLARE_CONCRETE_INSTRUCTION(DivByConstI, "div-by-const-i")
1318 DECLARE_HYDROGEN_ACCESSOR(Div) 1318 DECLARE_HYDROGEN_ACCESSOR(Div)
1319 1319
1320 private: 1320 private:
1321 int32_t divisor_; 1321 int32_t divisor_;
1322 }; 1322 };
1323 1323
1324 1324
1325 class LDivI V8_FINAL : public LTemplateInstruction<1, 2, 1> { 1325 class LDivI V8_FINAL : public LTemplateInstruction<1, 2, 1> {
1326 public: 1326 public:
1327 LDivI(LOperand* left, LOperand* right, LOperand* temp) { 1327 LDivI(LOperand* dividend, LOperand* divisor, LOperand* temp) {
1328 inputs_[0] = left; 1328 inputs_[0] = dividend;
1329 inputs_[1] = right; 1329 inputs_[1] = divisor;
1330 temps_[0] = temp; 1330 temps_[0] = temp;
1331 } 1331 }
1332 1332
1333 LOperand* left() { return inputs_[0]; } 1333 LOperand* dividend() { return inputs_[0]; }
1334 LOperand* right() { return inputs_[1]; } 1334 LOperand* divisor() { return inputs_[1]; }
1335 LOperand* temp() { return temps_[0]; } 1335 LOperand* temp() { return temps_[0]; }
1336 1336
1337 DECLARE_CONCRETE_INSTRUCTION(DivI, "div-i") 1337 DECLARE_CONCRETE_INSTRUCTION(DivI, "div-i")
1338 DECLARE_HYDROGEN_ACCESSOR(BinaryOperation) 1338 DECLARE_HYDROGEN_ACCESSOR(BinaryOperation)
1339 }; 1339 };
1340 1340
1341 1341
1342 class LDoubleToIntOrSmi V8_FINAL : public LTemplateInstruction<1, 1, 0> { 1342 class LDoubleToIntOrSmi V8_FINAL : public LTemplateInstruction<1, 1, 0> {
1343 public: 1343 public:
1344 explicit LDoubleToIntOrSmi(LOperand* value) { 1344 explicit LDoubleToIntOrSmi(LOperand* value) {
(...skipping 1746 matching lines...) Expand 10 before | Expand all | Expand 10 after
3091 3091
3092 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 3092 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
3093 }; 3093 };
3094 3094
3095 #undef DECLARE_HYDROGEN_ACCESSOR 3095 #undef DECLARE_HYDROGEN_ACCESSOR
3096 #undef DECLARE_CONCRETE_INSTRUCTION 3096 #undef DECLARE_CONCRETE_INSTRUCTION
3097 3097
3098 } } // namespace v8::internal 3098 } } // namespace v8::internal
3099 3099
3100 #endif // V8_ARM64_LITHIUM_ARM64_H_ 3100 #endif // V8_ARM64_LITHIUM_ARM64_H_
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698