Toggle GPU raster heuristics based on viewportEnabled.

Toggle GPU raster heuristics based on viewportEnabled.

On Android, viewportEnabled can be true and viewportMetaEnabled false
when "request desktop site" is enabled.  We still don't want to turn on
GPU raster unconditionally in this case.

The previous implementation checking viewportMetaEnabled worked largely
by coincidence due to lucky fallthrough and double-setting; change to
viewportEnabled instead which is better aligned with the intent, and add
a unit test for this case.

BUG=

Committed: https://crrev.com/1a7a5ed3257d5b8ed2d3f18fb090f5e5bf3b80aa
Cr-Commit-Position: refs/heads/master@{#407997}

[aelias_OOO_until_Jul13, 2016-07-09 02:04:40]

aelias@chromium.org changed reviewers:
+ vmiura@chromium.org

[aelias_OOO_until_Jul13, 2016-07-09 02:04:49]

Hi Victor, PTAL.

[aelias_OOO_until_Jul13, 2016-07-26 21:20:44]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[aelias_OOO_until_Jul13, 2016-07-26 21:21:03]

Hi Victor, PTAL again now that we're back from vacation.

[commit-bot: I haz the power, 2016-07-26 21:21:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 21:23:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 21:23:51]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[vmiura, 2016-07-26 21:35:54]

lgtm

[aelias_OOO_until_Jul13, 2016-07-26 21:42:32]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 21:43:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2016-07-26 22:31:04]

The CQ bit was unchecked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2016-07-26 22:31:07]

The CQ bit was checked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2016-07-26 22:31:07]

The patchset sent to the CQ was uploaded after l-g-t-m from vmiura@chromium.org
Link to the patchset: https://codereview.chromium.org/2127023002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-26 22:31:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 00:59:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-27 01:02:26]

Description was changed from

==========
Toggle GPU raster heuristics based on viewportEnabled.

On Android, viewportEnabled can be true and viewportMetaEnabled false
when "request desktop site" is enabled.  We still don't want to turn on
GPU raster unconditionally in this case.

The previous implementation checking viewportMetaEnabled worked largely
by coincidence due to lucky fallthrough and double-setting; change to
viewportEnabled instead which is better aligned with the intent, and add
a unit test for this case.

BUG=
==========

to

==========
Toggle GPU raster heuristics based on viewportEnabled.

On Android, viewportEnabled can be true and viewportMetaEnabled false
when "request desktop site" is enabled.  We still don't want to turn on
GPU raster unconditionally in this case.

The previous implementation checking viewportMetaEnabled worked largely
by coincidence due to lucky fallthrough and double-setting; change to
viewportEnabled instead which is better aligned with the intent, and add
a unit test for this case.

BUG=

Committed: https://crrev.com/1a7a5ed3257d5b8ed2d3f18fb090f5e5bf3b80aa
Cr-Commit-Position: refs/heads/master@{#407997}
==========

[commit-bot: I haz the power, 2016-07-27 01:02:28]

Patchset 4 (id:??) landed as
https://crrev.com/1a7a5ed3257d5b8ed2d3f18fb090f5e5bf3b80aa
Cr-Commit-Position: refs/heads/master@{#407997}