Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2127013002: 🎣 Reland of Make Android .build_configs aware of prebuilts and java sources (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 5 months ago
Reviewers:
Peter Wen
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Make Android .build_configs aware of prebuilts and java sources This information will be necessary for generating gradle projects for Android Studio. Reason for reland: javac and emma GN templates list .java files as inputs again. TBR=wnwen@chromium.org BUG=620034 Committed: https://crrev.com/a28a718e3bb30195a185279d09e9765538fac5e2 Cr-Commit-Position: refs/heads/master@{#404069}

Patch Set 1 #

Patch Set 2 : Fix GN not knowing the list of inputs in javac and emma rules #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -112 lines) Patch
M build/android/gyp/emma_instr.py View 1 4 chunks +18 lines, -7 lines 0 comments Download
M build/android/gyp/javac.py View 1 1 chunk +11 lines, -1 line 0 comments Download
M build/android/gyp/write_build_config.py View 1 6 chunks +36 lines, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 1 15 chunks +120 lines, -103 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
Created Reland of 🎣 Make Android .build_configs aware of prebuilts and java sources
4 years, 5 months ago (2016-07-07 01:23:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2127013002/100001
4 years, 5 months ago (2016-07-07 02:51:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 5 months ago (2016-07-07 04:00:15 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 04:00:17 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 04:02:28 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a28a718e3bb30195a185279d09e9765538fac5e2
Cr-Commit-Position: refs/heads/master@{#404069}

Powered by Google App Engine
This is Rietveld 408576698