SELECT element: Refer to m_lastOnChangeOption in HTMLSelectElement::optionIndexToBeShown().

SELECT element: Refer to m_lastOnChangeOption in HTMLSelectElement::optionIndexToBeShown().

This is a preparation to remove O(N) operations in optionIndexToBeShown().

Use m_lastOnChangeOption instead of selectedIndex in optionIndexToBeShown(). We
need to update selectOption() too so that m_lastOnChangeOption is updated before
calling LayoutObject::updateFromElement.  LayoutMenuList::updateFromElement
calls optionIndexToBeShown().

selectedIndex() is O(N), and m_lastOnChangeOption->index() is also O(N). So this
CL doesn't change complexity of optionIndexToBeShown().

BUG=577989
R=keishi@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/6b34b48ae7a7f74f51d25e3b452e5782ebae7584

[tkent, 2016-07-07 01:28:14]

Patchset #1 (id:1) has been deleted

[tkent, 2016-07-07 01:28:50]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-07-07 01:28:50]

Keishi, would you review this please?

[keishi, 2016-07-07 03:08:41]

LGTM

[tkent, 2016-07-07 03:45:12]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-07-07 03:45:12]

The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org
Link to the patchset: https://codereview.chromium.org/2127003003/#ps40001
(title: "Update m_lastOnChangeOption in
HTMLSelectElement::restoreFormControlState")

[commit-bot: I haz the power, 2016-07-07 03:45:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-07-07 04:09:28]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2016-07-07 04:57:48]

Description was changed from

==========
SELECT element: Refer to m_lastOnChangeOption in
HTMLSelectElement::optionIndexToBeShown().

This is a preparation to remove O(N) operations in optionIndexToBeShown().

Use m_lastOnChangeOption instead of selectedIndex in optionIndexToBeShown(). We
need to update selectOption() too so that m_lastOnChangeOption is updated before
calling LayoutObject::updateFromElement.  LayoutMenuList::updateFromElement
calls optionIndexToBeShown().

selectOption() is O(N), and m_lastOnChangeOption->index() is also O(N). So this
CL doesn't change complexity of optionIndexToBeShown().

BUG=577989
==========

to

==========
SELECT element: Refer to m_lastOnChangeOption in
HTMLSelectElement::optionIndexToBeShown().

This is a preparation to remove O(N) operations in optionIndexToBeShown().

Use m_lastOnChangeOption instead of selectedIndex in optionIndexToBeShown(). We
need to update selectOption() too so that m_lastOnChangeOption is updated before
calling LayoutObject::updateFromElement.  LayoutMenuList::updateFromElement
calls optionIndexToBeShown().

selectedIndex() is O(N), and m_lastOnChangeOption->index() is also O(N). So this
CL doesn't change complexity of optionIndexToBeShown().

BUG=577989
==========

[tkent, 2016-07-07 05:01:09]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-07-07 05:01:10]

The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org
Link to the patchset: https://codereview.chromium.org/2127003003/#ps60001
(title: "typo")

[commit-bot: I haz the power, 2016-07-07 05:01:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 06:43:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 06:43:46]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2016-07-07 06:46:59]

Description was changed from

==========
SELECT element: Refer to m_lastOnChangeOption in
HTMLSelectElement::optionIndexToBeShown().

This is a preparation to remove O(N) operations in optionIndexToBeShown().

Use m_lastOnChangeOption instead of selectedIndex in optionIndexToBeShown(). We
need to update selectOption() too so that m_lastOnChangeOption is updated before
calling LayoutObject::updateFromElement.  LayoutMenuList::updateFromElement
calls optionIndexToBeShown().

selectedIndex() is O(N), and m_lastOnChangeOption->index() is also O(N). So this
CL doesn't change complexity of optionIndexToBeShown().

BUG=577989
==========

to

==========
SELECT element: Refer to m_lastOnChangeOption in
HTMLSelectElement::optionIndexToBeShown().

This is a preparation to remove O(N) operations in optionIndexToBeShown().

Use m_lastOnChangeOption instead of selectedIndex in optionIndexToBeShown(). We
need to update selectOption() too so that m_lastOnChangeOption is updated before
calling LayoutObject::updateFromElement.  LayoutMenuList::updateFromElement
calls optionIndexToBeShown().

selectedIndex() is O(N), and m_lastOnChangeOption->index() is also O(N). So this
CL doesn't change complexity of optionIndexToBeShown().

BUG=577989
R=keishi@chromium.org

Committed: https://crrev.com/6b34b48ae7a7f74f51d25e3b452e5782ebae7584
Cr-Commit-Position: refs/heads/master@{#404091}
==========

[commit-bot: I haz the power, 2016-07-07 06:47:00]

Patchset 3 (id:??) landed as
https://crrev.com/6b34b48ae7a7f74f51d25e3b452e5782ebae7584
Cr-Commit-Position: refs/heads/master@{#404091}

[tkent, 2016-07-07 06:48:32]

Description was changed from

==========
SELECT element: Refer to m_lastOnChangeOption in
HTMLSelectElement::optionIndexToBeShown().

This is a preparation to remove O(N) operations in optionIndexToBeShown().

Use m_lastOnChangeOption instead of selectedIndex in optionIndexToBeShown(). We
need to update selectOption() too so that m_lastOnChangeOption is updated before
calling LayoutObject::updateFromElement.  LayoutMenuList::updateFromElement
calls optionIndexToBeShown().

selectedIndex() is O(N), and m_lastOnChangeOption->index() is also O(N). So this
CL doesn't change complexity of optionIndexToBeShown().

BUG=577989
R=keishi@chromium.org

Committed: https://crrev.com/6b34b48ae7a7f74f51d25e3b452e5782ebae7584
Cr-Commit-Position: refs/heads/master@{#404091}
==========

to

==========
SELECT element: Refer to m_lastOnChangeOption in
HTMLSelectElement::optionIndexToBeShown().

This is a preparation to remove O(N) operations in optionIndexToBeShown().

Use m_lastOnChangeOption instead of selectedIndex in optionIndexToBeShown(). We
need to update selectOption() too so that m_lastOnChangeOption is updated before
calling LayoutObject::updateFromElement.  LayoutMenuList::updateFromElement
calls optionIndexToBeShown().

selectedIndex() is O(N), and m_lastOnChangeOption->index() is also O(N). So this
CL doesn't change complexity of optionIndexToBeShown().

BUG=577989
R=keishi@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/6b34b48ae7a7f74f51d25e3b452e...
==========

[tkent, 2016-07-07 06:48:34]

Committed patchset #3 (id:60001) manually as
6b34b48ae7a7f74f51d25e3b452e5782ebae7584 (presubmit successful).