DevTools: Convert mimeTypeByExtension and mimeTypeByName to Map

DevTools: Convert mimeTypeByExtension and mimeTypeByName to Map

Filenames corresponding to Object properties would return functions instead of undefined

BUG=622644
Committed: https://crrev.com/14c7fe37a4c3821328e4f930626cc60616b1f14e
Cr-Commit-Position: refs/heads/master@{#404299}

[einbinder, 2016-07-06 23:56:51]

einbinder@chromium.org changed reviewers:
+ dgozman@chromium.org

[einbinder, 2016-07-06 23:56:52]

I looked around and didn't find any other obvious cases. Is there anywhere else
in the code that might have Objects where we want Maps?

[einbinder, 2016-07-07 00:17:10]

Description was changed from

==========
Convert mimeTypeByExtension and mimeTypeByName to Map

Filenames corresponding to Object properties would return functions instead of
undefined

BUG=622644
==========

to

==========
DevTools: Convert mimeTypeByExtension and mimeTypeByName to Map

Filenames corresponding to Object properties would return functions instead of
undefined

BUG=622644
==========

[caseq, 2016-07-07 00:18:20]

caseq@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-07-07 00:18:21]

https://codereview.chromium.org/2126973002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/common/ResourceType.js
(right):

https://codereview.chromium.org/2126973002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/common/ResourceType.js:210:
WebInspector.ResourceType.mimeTypeByName = new Map([
while you're here, please make these private (i.e. prefix with underscore).

[einbinder, 2016-07-07 00:46:09]

https://codereview.chromium.org/2126973002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/common/ResourceType.js
(right):

https://codereview.chromium.org/2126973002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/common/ResourceType.js:210:
WebInspector.ResourceType.mimeTypeByName = new Map([
On 2016/07/07 00:18:21, caseq wrote:
> while you're here, please make these private (i.e. prefix with underscore).

Done.

[pfeldman, 2016-07-07 04:22:25]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-07-07 04:22:25]

lgtm

[einbinder, 2016-07-07 19:33:51]

ptal @ test

[dgozman, 2016-07-07 19:35:29]

lgtm. Thanks!

[einbinder, 2016-07-07 19:35:40]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2016-07-07 19:35:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2126973002/#ps60001
(title: "Better test")

[commit-bot: I haz the power, 2016-07-07 19:36:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 21:24:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 21:24:31]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[einbinder, 2016-07-08 00:03:44]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2016-07-08 00:04:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 01:20:40]

Description was changed from

==========
DevTools: Convert mimeTypeByExtension and mimeTypeByName to Map

Filenames corresponding to Object properties would return functions instead of
undefined

BUG=622644
==========

to

==========
DevTools: Convert mimeTypeByExtension and mimeTypeByName to Map

Filenames corresponding to Object properties would return functions instead of
undefined

BUG=622644
==========

[commit-bot: I haz the power, 2016-07-08 01:20:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-08 01:20:56]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 01:23:20]

Description was changed from

==========
DevTools: Convert mimeTypeByExtension and mimeTypeByName to Map

Filenames corresponding to Object properties would return functions instead of
undefined

BUG=622644
==========

to

==========
DevTools: Convert mimeTypeByExtension and mimeTypeByName to Map

Filenames corresponding to Object properties would return functions instead of
undefined

BUG=622644

Committed: https://crrev.com/14c7fe37a4c3821328e4f930626cc60616b1f14e
Cr-Commit-Position: refs/heads/master@{#404299}
==========

[commit-bot: I haz the power, 2016-07-08 01:23:21]

Patchset 4 (id:??) landed as
https://crrev.com/14c7fe37a4c3821328e4f930626cc60616b1f14e
Cr-Commit-Position: refs/heads/master@{#404299}