Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 2126973002: DevTools: Convert mimeTypeByExtension and mimeTypeByName to Map (Closed)

Created:
4 years, 5 months ago by einbinder
Modified:
4 years, 5 months ago
Reviewers:
caseq, dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Convert mimeTypeByExtension and mimeTypeByName to Map Filenames corresponding to Object properties would return functions instead of undefined BUG=622644 Committed: https://crrev.com/14c7fe37a4c3821328e4f930626cc60616b1f14e Cr-Commit-Position: refs/heads/master@{#404299}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make maps private #

Patch Set 3 : Add test #

Patch Set 4 : Better test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -62 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model-expected.txt View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/ResourceType.js View 1 1 chunk +62 lines, -62 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
einbinder
I looked around and didn't find any other obvious cases. Is there anywhere else in ...
4 years, 5 months ago (2016-07-06 23:56:52 UTC) #2
caseq
https://codereview.chromium.org/2126973002/diff/1/third_party/WebKit/Source/devtools/front_end/common/ResourceType.js File third_party/WebKit/Source/devtools/front_end/common/ResourceType.js (right): https://codereview.chromium.org/2126973002/diff/1/third_party/WebKit/Source/devtools/front_end/common/ResourceType.js#newcode210 third_party/WebKit/Source/devtools/front_end/common/ResourceType.js:210: WebInspector.ResourceType.mimeTypeByName = new Map([ while you're here, please make ...
4 years, 5 months ago (2016-07-07 00:18:21 UTC) #5
einbinder
https://codereview.chromium.org/2126973002/diff/1/third_party/WebKit/Source/devtools/front_end/common/ResourceType.js File third_party/WebKit/Source/devtools/front_end/common/ResourceType.js (right): https://codereview.chromium.org/2126973002/diff/1/third_party/WebKit/Source/devtools/front_end/common/ResourceType.js#newcode210 third_party/WebKit/Source/devtools/front_end/common/ResourceType.js:210: WebInspector.ResourceType.mimeTypeByName = new Map([ On 2016/07/07 00:18:21, caseq wrote: ...
4 years, 5 months ago (2016-07-07 00:46:09 UTC) #6
pfeldman
lgtm
4 years, 5 months ago (2016-07-07 04:22:25 UTC) #8
einbinder
ptal @ test
4 years, 5 months ago (2016-07-07 19:33:51 UTC) #9
dgozman
lgtm. Thanks!
4 years, 5 months ago (2016-07-07 19:35:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126973002/60001
4 years, 5 months ago (2016-07-07 19:36:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/251676)
4 years, 5 months ago (2016-07-07 21:24:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126973002/60001
4 years, 5 months ago (2016-07-08 00:04:21 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-08 01:20:41 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 01:20:56 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 01:23:21 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/14c7fe37a4c3821328e4f930626cc60616b1f14e
Cr-Commit-Position: refs/heads/master@{#404299}

Powered by Google App Engine
This is Rietveld 408576698