Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2126963002: mash: Move multi_profile_uma.* to ash/common. (Closed)

Created:
4 years, 5 months ago by msw
Modified:
4 years, 5 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, sadrul, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move multi_profile_uma.* to ash/common. tools/git/move_source_file.py ash/multi_profile_uma* ash/common/ These files are used by ash/system/user. BUG=619636 TEST=compiles; no behavior changes. R=jamescook@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787 Cr-Commit-Position: refs/heads/master@{#403993}

Patch Set 1 #

Patch Set 2 : Remove unused includes. #

Patch Set 3 : Sync and rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -157 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M ash/ash.gyp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/common/multi_profile_uma.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/multi_profile_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/multi_profile_uma.h View 1 chunk +0 lines, -85 lines 0 comments Download
D ash/multi_profile_uma.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M ash/system/user/user_view.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory/tab_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
msw
Hey James, please take a look; thanks! (simple move)
4 years, 5 months ago (2016-07-06 23:04:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126963002/20001
4 years, 5 months ago (2016-07-06 23:11:10 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126963002/40001
4 years, 5 months ago (2016-07-06 23:15:13 UTC) #5
James Cook
LGTM
4 years, 5 months ago (2016-07-06 23:19:05 UTC) #6
msw
+TBR Scott for chrome/*
4 years, 5 months ago (2016-07-06 23:19:45 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-06 23:54:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126963002/40001
4 years, 5 months ago (2016-07-06 23:55:49 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-07 00:01:17 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 00:01:18 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 00:03:41 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787
Cr-Commit-Position: refs/heads/master@{#403993}

Powered by Google App Engine
This is Rietveld 408576698