[Material][Mac] Fix the indicator and close button in a dragged tab

[Material][Mac] Fix the indicator and close button in a dragged tab

Override hasDarkTheme: in TabWindowOverlayWindow so that we
return the correct value. Make sure that the indicator icon updates its
color when it moves to a new window.

BUG=621348
Committed: https://crrev.com/a63ec95961ece7c912ddd2892d0435c331a0d4c7
Cr-Commit-Position: refs/heads/master@{#404438}

[spqchan, 2016-07-06 22:58:02]

Description was changed from

==========
[Material][Mac] Updates the alert indicator in the tab drag

BUG=621348
==========

to

==========
[Material][Mac] Update the alert indicator in the tab drag

BUG=621348
==========

[spqchan, 2016-07-06 22:58:10]

Description was changed from

==========
[Material][Mac] Update the alert indicator in the tab drag

BUG=621348
==========

to

==========
[Material][Mac] Update the alert indicator in the a tab drag

BUG=621348
==========

[spqchan, 2016-07-07 00:34:05]

Description was changed from

==========
[Material][Mac] Update the alert indicator in the a tab drag

BUG=621348
==========

to

==========
[Material][Mac] Fix the indicator and close button in a dragged tab

BUG=621348
==========

[spqchan, 2016-07-07 00:37:01]

Description was changed from

==========
[Material][Mac] Fix the indicator and close button in a dragged tab

BUG=621348
==========

to

==========
[Material][Mac] Fix the indicator and close button in a dragged tab

Override hasDarkTheme: in TabWindowOverlayWindow so that we
return the correct value. Make sure that the indicator icon updates its
color when it moves to a new window.

BUG=621348
==========

[spqchan, 2016-07-07 00:39:55]

spqchan@chromium.org changed reviewers:
+ shrike@chromium.org

[spqchan, 2016-07-07 00:39:56]

PTAL

[shrike, 2016-07-07 00:55:24]

On 2016/07/07 00:39:56, spqchan wrote:
> PTAL

Hello spqchan@,

For whatever reason, I don't notice a change with this patch applied. The moment
I drag the YouTube tab out of the window the speaker turns black, and it never
changes back.

I was also experimenting with a dark theme (Black red shards), not in Incognito
mode. I noticed there that the speaker disappears (I think maybe it's just so
dark it can't be seen) but then the close button "x" turns red to match the tab
title text. It stays that way until you mouse over it.

[spqchan, 2016-07-07 18:42:12]

On 2016/07/07 00:55:24, shrike wrote:
> On 2016/07/07 00:39:56, spqchan wrote:
> > PTAL
> 
> Hello spqchan@,
> 
> For whatever reason, I don't notice a change with this patch applied. The
moment
> I drag the YouTube tab out of the window the speaker turns black, and it never
> changes back.
> 
> I was also experimenting with a dark theme (Black red shards), not in
Incognito
> mode. I noticed there that the speaker disappears (I think maybe it's just so
> dark it can't be seen) but then the close button "x" turns red to match the
tab
> title text. It stays that way until you mouse over it.

That's strange. It's working for me on my laptop and my desktop. I can't
reproduce the things you listed.
I also noticed that the close button was recently fixed in Canary

For the dark theme, are you testing with the Minnesota Wild theme?

[shrike, 2016-07-07 23:14:27]

On 2016/07/07 18:42:12, spqchan wrote:
> On 2016/07/07 00:55:24, shrike wrote:
> > On 2016/07/07 00:39:56, spqchan wrote:
> > > PTAL
> > 
> > Hello spqchan@,
> > 
> > For whatever reason, I don't notice a change with this patch applied. The
> moment
> > I drag the YouTube tab out of the window the speaker turns black, and it
never
> > changes back.
> > 
> > I was also experimenting with a dark theme (Black red shards), not in
> Incognito
> > mode. I noticed there that the speaker disappears (I think maybe it's just
so
> > dark it can't be seen) but then the close button "x" turns red to match the
> tab
> > title text. It stays that way until you mouse over it.
> 
> That's strange. It's working for me on my laptop and my desktop. I can't
> reproduce the things you listed.
> I also noticed that the close button was recently fixed in Canary
> 
> For the dark theme, are you testing with the Minnesota Wild theme?

The theme I'm using is called "Black red shards".

I started over with a fresh branch and after applying your cl the speaker icon
is looking correct (and the close button too). Maybe I was in the wrong branch
yesterday.

lgtm

[spqchan, 2016-07-08 17:17:26]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-07-08 17:17:27]

Thanks!

+rsesek for OWNERS

[Robert Sesek, 2016-07-08 17:18:59]

lgtm

[spqchan, 2016-07-08 17:20:44]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-07-08 17:21:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 18:06:40]

Description was changed from

==========
[Material][Mac] Fix the indicator and close button in a dragged tab

Override hasDarkTheme: in TabWindowOverlayWindow so that we
return the correct value. Make sure that the indicator icon updates its
color when it moves to a new window.

BUG=621348
==========

to

==========
[Material][Mac] Fix the indicator and close button in a dragged tab

Override hasDarkTheme: in TabWindowOverlayWindow so that we
return the correct value. Make sure that the indicator icon updates its
color when it moves to a new window.

BUG=621348
==========

[commit-bot: I haz the power, 2016-07-08 18:06:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-08 18:09:48]

Description was changed from

==========
[Material][Mac] Fix the indicator and close button in a dragged tab

Override hasDarkTheme: in TabWindowOverlayWindow so that we
return the correct value. Make sure that the indicator icon updates its
color when it moves to a new window.

BUG=621348
==========

to

==========
[Material][Mac] Fix the indicator and close button in a dragged tab

Override hasDarkTheme: in TabWindowOverlayWindow so that we
return the correct value. Make sure that the indicator icon updates its
color when it moves to a new window.

BUG=621348

Committed: https://crrev.com/a63ec95961ece7c912ddd2892d0435c331a0d4c7
Cr-Commit-Position: refs/heads/master@{#404438}
==========

[commit-bot: I haz the power, 2016-07-08 18:09:49]

Patchset 2 (id:??) landed as
https://crrev.com/a63ec95961ece7c912ddd2892d0435c331a0d4c7
Cr-Commit-Position: refs/heads/master@{#404438}