Issue 212693006: Remove V8_INLINE from v8-util.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212693006: Remove V8_INLINE from v8-util.h. (Closed)

Created:
6 years, 8 months ago by vogelheim

Modified:
6 years, 8 months ago

Reviewers:
dcarney, jochen (gone - plz use gerrit)

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove V8_INLINE from v8-util.h. (These have been causing compilation problems on some platforms. For VS, V8_INLINE turns into 'force inline', which will then cause a problem when the compiler won't actually inline. Search for "C4714 warning" for details.) BUG= R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20432

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
	M	include/v8-util.h	View		6 chunks	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vogelheim

6 years, 8 months ago (2014-04-02 12:07:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r20432 (presubmit successful).

Expand Messages | Collapse Messages