Issue 212693003: Fix handling of union on DictionaryTypeMask.

Issue 212693003: Fix handling of union on DictionaryTypeMask. (Closed)

Created:
6 years, 9 months ago by herhut

Modified:
6 years, 9 months ago

Reviewers:
karlklose, floitsch

CC:
reviews_dartlang.org, floitsch, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix handling of union on DictionaryTypeMask. BUG= http://dartbug.com/17856 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=34500

Patch Set 2 : improved handling of map keys #

Total comments: 1

Patch Set 3 : smaller patch that only fixes issue #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -1 line)			Patch
	M	sdk/lib/_internal/compiler/implementation/types/dictionary_type_mask.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	tests/compiler/dart2js_extra/17856_test.dart	View		1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

herhut

I realized last night that keys in maps could be used to escape traced items ...

6 years, 9 months ago (2014-03-28 08:02:37 UTC) #2

floitsch

FYI. Please split the fix and the rest. https://codereview.chromium.org/212693003/diff/20001/sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart File sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart (right): https://codereview.chromium.org/212693003/diff/20001/sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart#newcode64 sdk/lib/_internal/compiler/implementation/inferrer/node_tracer.dart:64: 'keys' ...

6 years, 9 months ago (2014-03-28 09:53:03 UTC) #3

herhut

Split off the other improvement into own CL at https://codereview.chromium.org/216673003

6 years, 9 months ago (2014-03-28 10:48:36 UTC) #4

herhut

6 years, 9 months ago (2014-03-28 12:19:08 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r34500 (presubmit successful).

Expand Messages | Collapse Messages