chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js - Issue 212693002: Do not cancel request when an error occurs in a webRequest event handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js

Issue 212693002: Do not cancel request when an error occurs in a webRequest event handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/test/data/extensions/api_test/webrequest/test_api.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js b/chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js

index 7e514ab6ec565e29f09d839af7a7a393b32295bb..789df03fe29d3a6b91528d72f996e2360501503f 100644

--- a/chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js

@@ -90,7 +90,7 @@ WebRequestEventImpl.prototype.addListener =

eventName, subEventName, requestId, result);

} catch (e) {

webRequestInternal.eventHandled(

- eventName, subEventName, requestId, {cancel: true});

+ eventName, subEventName, requestId);

throw e;

}

};