Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6145)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api.h

Issue 212693002: Do not cancel request when an error occurs in a webRequest event handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_request/web_request_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/web_request/web_request_api.h
diff --git a/chrome/browser/extensions/api/web_request/web_request_api.h b/chrome/browser/extensions/api/web_request/web_request_api.h
index 9ae447dddcc3e9235ec7ce77005a36cec6156fba..c3bf24c6d046339ef86be84a69462474b551c5a6 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api.h
+++ b/chrome/browser/extensions/api/web_request/web_request_api.h
@@ -487,11 +487,11 @@ class WebRequestEventHandled : public SyncIOThreadExtensionFunction {
protected:
virtual ~WebRequestEventHandled() {}
- // Cancels and unblocks the network request, and sets error_ such that the
- // developer console will show the respective error message. Use this function
- // to handle incorrect requests from the extension that cannot be detected by
- // the schema validator.
- void CancelWithError(
+ // Unblocks the network request and sets |error_| such that the developer
+ // console will show the respective error message. Use this function to handle
+ // incorrect requests from the extension that cannot be detected by the schema
+ // validator.
+ void RespondWithError(
const std::string& event_name,
const std::string& sub_event_name,
uint64 request_id,
« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_request/web_request_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698