Do not cancel request when an error occurs in a webRequest event handler

chrome/test/data/extensions/api_test/webrequest/test_blocking.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var pass = chrome.test.callbackPass;
 
 // Constants as functions, not to be called until after runTests.
 function getURLEchoUserAgent() {
   return getServerURL('echoheader?User-Agent');
 }
@@ skipping 107 matching lines @@
       [  // event order
         ["onBeforeRequest", "onBeforeSendHeaders", "onSendHeaders",
          "onHeadersReceived", "onErrorOccurred"]
       ],
       {urls: ["<all_urls>"]},  // filter
       ["blocking"]);
     navigateAndWait(getURLHttpSimpleLoad());
   },
 
   // Navigates to a page and provides invalid header information. The request
-  // gets canceled.
-  function simpleLoadCancelledOnReceiveHeadersInvalidHeaders() {
+  // should continue as if the headers were not changed.
+  function simpleLoadIgnoreOnBeforeSendHeadersInvalidHeaders() {
     expect(
       [  // events
         { label: "onBeforeRequest",
           event: "onBeforeRequest",
           details: {
             method: "GET",
             type: "main_frame",
             url: getURLHttpSimpleLoad(),
             frameUrl: getURLHttpSimpleLoad()
           },
         },
         { label: "onBeforeSendHeaders",
           event: "onBeforeSendHeaders",
           details: {
             url: getURLHttpSimpleLoad(),
-            // Note: no requestHeaders because we don't ask for them.
+            requestHeadersValid: true
           },
           retval: {requestHeaders: [{name: "User-Agent"}]}
         },
-        // Cancelling is considered an error.
-        { label: "onErrorOccurred",
-          event: "onErrorOccurred",
+        // The headers were invalid, so they should not be modified.
+        // TODO(robwu): Test whether an error is logged to the console.
+        { label: "onSendHeaders",
+          event: "onSendHeaders",
+          details: {
+            url: getURLHttpSimpleLoad(),
+            requestHeadersValid: true
+          }
+        },
+        { label: "onHeadersReceived",
+          event: "onHeadersReceived",
+          details: {
+            url: getURLHttpSimpleLoad(),
+            statusLine: "HTTP/1.1 200 OK",
+          }
+        },
+        { label: "onResponseStarted",
+          event: "onResponseStarted",
           details: {
             url: getURLHttpSimpleLoad(),
             fromCache: false,
-            error: "net::ERR_BLOCKED_BY_CLIENT"
-            // Request to chrome-extension:// url has no IP.
+            statusCode: 200,
+            ip: "127.0.0.1",
+            statusLine: "HTTP/1.1 200 OK",
+          }
+        },
+        { label: "onCompleted",
+          event: "onCompleted",
+          details: {
+            url: getURLHttpSimpleLoad(),
+            fromCache: false,
+            statusCode: 200,
+            ip: "127.0.0.1",
+            statusLine: "HTTP/1.1 200 OK",
           }
         },
       ],
       [  // event order
-        ["onBeforeRequest", "onBeforeSendHeaders", "onErrorOccurred"]
+        ["onBeforeRequest", "onBeforeSendHeaders", "onSendHeaders",
+         "onHeadersReceived", "onResponseStarted", "onCompleted"]
       ],
       {urls: ["<all_urls>"]},  // filter
-      ["blocking"]);
+      ["blocking", "requestHeaders"]);
     navigateAndWait(getURLHttpSimpleLoad());
   },
 
   // Navigates to a page and provides invalid header information. The request
-  // gets canceled.
-  function simpleLoadCancelledOnReceiveHeadersInvalidResponse() {
+  // should continue as if the headers were not changed.
+  function simpleLoadIgnoreOnBeforeSendHeadersInvalidResponse() {
     expect(
       [  // events
         { label: "onBeforeRequest",
           event: "onBeforeRequest",
           details: {
             method: "GET",
             type: "main_frame",
             url: getURLHttpSimpleLoad(),
             frameUrl: getURLHttpSimpleLoad()
           },
         },
         { label: "onBeforeSendHeaders",
           event: "onBeforeSendHeaders",
           details: {
             url: getURLHttpSimpleLoad(),
-            // Note: no requestHeaders because we don't ask for them.
+            requestHeadersValid: true
           },
           retval: {foo: "bar"}
         },
-        // Cancelling is considered an error.
-        { label: "onErrorOccurred",
-          event: "onErrorOccurred",
+        // TODO(robwu): Test whether an error is logged to the console.
+        { label: "onSendHeaders",
+          event: "onSendHeaders",
+          details: {
+            url: getURLHttpSimpleLoad(),
+            requestHeadersValid: true
+          }
+        },
+        { label: "onHeadersReceived",
+          event: "onHeadersReceived",
+          details: {
+            url: getURLHttpSimpleLoad(),
+            statusLine: "HTTP/1.1 200 OK",
+          }
+        },
+        { label: "onResponseStarted",
+          event: "onResponseStarted",
           details: {
             url: getURLHttpSimpleLoad(),
             fromCache: false,
-            error: "net::ERR_BLOCKED_BY_CLIENT"
-            // Request to chrome-extension:// url has no IP.
+            statusCode: 200,
+            ip: "127.0.0.1",
+            statusLine: "HTTP/1.1 200 OK",
+          }
+        },
+        { label: "onCompleted",
+          event: "onCompleted",
+          details: {
+            url: getURLHttpSimpleLoad(),
+            fromCache: false,
+            statusCode: 200,
+            ip: "127.0.0.1",
+            statusLine: "HTTP/1.1 200 OK",
           }
         },
       ],
       [  // event order
-        ["onBeforeRequest", "onBeforeSendHeaders", "onErrorOccurred"]
+        ["onBeforeRequest", "onBeforeSendHeaders", "onSendHeaders",
+         "onHeadersReceived", "onResponseStarted", "onCompleted"]
       ],
       {urls: ["<all_urls>"]},  // filter
-      ["blocking"]);
+      ["blocking", "requestHeaders"]);
     navigateAndWait(getURLHttpSimpleLoad());
   },
 
   // Navigates to a page with a blocking handler that redirects to a different
   // page.
   function complexLoadRedirected() {
     expect(
       [  // events
         { label: "onBeforeRequest-1",
           event: "onBeforeRequest",
@@ skipping 715 matching lines @@
     // Check the page content for our modified User-Agent string.
     navigateAndWait(getURL("simpleLoad/a.html"), function() {
         var req = new XMLHttpRequest();
         var asynchronous = true;
         req.open("GET", getURLHttpXHRData(), asynchronous);
         req.send(null);
         navigateAndWait(getURL("complexLoad/b.jpg"));
     });
   },
 ]);