Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: content/browser/accessibility/browser_accessibility_manager.cc

Issue 21269002: Make AccessibilityNodeData more compact. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix windows compile Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager.cc b/content/browser/accessibility/browser_accessibility_manager.cc
index 7def57459f929cc288960053b35e05f58fc358c5..10c8b54c40de7f4f2a28ba81dbe1a57ab08337fa 100644
--- a/content/browser/accessibility/browser_accessibility_manager.cc
+++ b/content/browser/accessibility/browser_accessibility_manager.cc
@@ -338,11 +338,13 @@ bool BrowserAccessibilityManager::UpdateNode(const AccessibilityNodeData& src) {
instance = CreateNode(NULL, src.id, 0);
}
- if (src.bool_attributes.find(
- AccessibilityNodeData::ATTR_UPDATE_LOCATION_ONLY) !=
- src.bool_attributes.end()) {
- instance->SetLocation(src.location);
- return true;
+ // TODO(dmazzoni): avoid a linear scan here.
+ for (size_t i = 0; i < src.bool_attributes.size(); i++) {
+ if (src.bool_attributes[i].first ==
+ AccessibilityNodeData::ATTR_UPDATE_LOCATION_ONLY) {
+ instance->SetLocation(src.location);
+ return true;
+ }
}
// Update all of the node-specific data, like its role, state, name, etc.

Powered by Google App Engine
This is Rietveld 408576698