Make AccessibilityNodeData more compact.

content/common/accessibility_node_data.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_ACCESSIBILITY_NODE_DATA_H_
 #define CONTENT_COMMON_ACCESSIBILITY_NODE_DATA_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 173 matching lines @@
 
     // Attributes that could apply to any node.
     ATTR_ACCESS_KEY,
     ATTR_ACTION,
     ATTR_CONTAINER_LIVE_RELEVANT,
     ATTR_CONTAINER_LIVE_STATUS,
     ATTR_DESCRIPTION,
     ATTR_DISPLAY,
     ATTR_HELP,
     ATTR_HTML_TAG,
+    ATTR_NAME,
     ATTR_LIVE_RELEVANT,
     ATTR_LIVE_STATUS,
     ATTR_ROLE,
     ATTR_SHORTCUT,
     ATTR_URL,
+    ATTR_VALUE,
   };
 
   enum IntAttribute {
     // Scrollable container attributes.
     ATTR_SCROLL_X,
     ATTR_SCROLL_X_MIN,
     ATTR_SCROLL_X_MAX,
     ATTR_SCROLL_Y,
     ATTR_SCROLL_Y_MIN,
     ATTR_SCROLL_Y_MAX,
@@ skipping 60 matching lines @@
     ATTR_ARIA_READONLY,
 
     // Writeable attributes
     ATTR_CAN_SET_VALUE,
 
     // If this is set, all of the other fields in this struct should
     // be ignored and only the locations should change.
     ATTR_UPDATE_LOCATION_ONLY,
   };
 
+  enum IntListAttribute {
+    // Ids of nodes that are children of this node logically, but are
+    // not children of this node in the tree structure. As an example,
+    // a table cell is a child of a row, and an 'indirect' child of a
+    // column.
+    ATTR_INDIRECT_CHILD_IDS,
+
+    // Character indices where line breaks occur.
+    ATTR_LINE_BREAKS,
+
+    // For a table, the cell ids in row-major order, with duplicate entries
+    // when there's a rowspan or colspan, and with -1 for missing cells.
+    // There are always exactly rows * columns entries.
+    ATTR_CELL_IDS,
+
+    // For a table, the unique cell ids in row-major order of their first
+    // occurrence.
+    ATTR_UNIQUE_CELL_IDS
+  };
+
   AccessibilityNodeData();
   virtual ~AccessibilityNodeData();
 
+  void AddStringAttribute(StringAttribute attribute,
+                          const std::string& value);
+  void AddIntAttribute(IntAttribute attribute, int value);
+  void AddFloatAttribute(FloatAttribute attribute, float value);
+  void AddBoolAttribute(BoolAttribute attribute, bool value);
+  void AddIntListAttribute(IntListAttribute attribute,
+                           const std::vector<int32>& value);
+
+  void SetName(std::string name);

[aboxhall, 2013/08/07 20:22:06]

This is only used in testing, right?

[dmazzoni, 2013/08/07 20:23:40]

Yes.

[aboxhall, 2013/08/07 20:25:17]

Is that worth a comment?

+
   #ifndef NDEBUG
   virtual std::string DebugString(bool recursive) const;
   #endif
 
   // This is a simple serializable struct. All member variables should be
   // public and copyable.
   int32 id;
-  string16 name;
-  string16 value;
   Role role;
   uint32 state;
   gfx::Rect location;
-  std::map<StringAttribute, string16> string_attributes;
-  std::map<IntAttribute, int32> int_attributes;
-  std::map<FloatAttribute, float> float_attributes;
-  std::map<BoolAttribute, bool> bool_attributes;
+  std::vector<std::pair<StringAttribute, std::string> > string_attributes;
+  std::vector<std::pair<IntAttribute, int32> > int_attributes;
+  std::vector<std::pair<FloatAttribute, float> > float_attributes;
+  std::vector<std::pair<BoolAttribute, bool> > bool_attributes;
+  std::vector<std::pair<IntListAttribute, std::vector<int32> > >
+      intlist_attributes;
+  std::vector<std::pair<std::string, std::string> > html_attributes;
   std::vector<int32> child_ids;
-  std::vector<int32> indirect_child_ids;
-  std::vector<std::pair<string16, string16> > html_attributes;
-  std::vector<int32> line_breaks;
-
-  // For a table, the cell ids in row-major order, with duplicate entries
-  // when there's a rowspan or colspan, and with -1 for missing cells.
-  // There are always exactly rows * columns entries.
-  std::vector<int32> cell_ids;
-
-  // For a table, the unique cell ids in row-major order of their first
-  // occurrence.
-  std::vector<int32> unique_cell_ids;
 };
 
 // For testing and debugging only: this subclass of AccessibilityNodeData
 // is used to represent a whole tree of accessibility nodes, where each
 // node owns its children. This makes it easy to print the tree structure
 // or search it recursively.
 struct CONTENT_EXPORT AccessibilityNodeDataTreeNode
     : public AccessibilityNodeData {
   AccessibilityNodeDataTreeNode();
   virtual ~AccessibilityNodeDataTreeNode();
@@ skipping 12 matching lines @@
 // build a tree of AccessibilityNodeDataTreeNode objects for easier
 // testing and debugging, where each node contains its children.
 // The |dst| argument will become the root of the new tree.
 void MakeAccessibilityNodeDataTree(
     const std::vector<AccessibilityNodeData>& src,
     AccessibilityNodeDataTreeNode* dst);
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_ACCESSIBILITY_NODE_DATA_H_